Issue 100133004: Bucket unknown symbols by PC and demangle native symbols

Issue 100133004: Bucket unknown symbols by PC and demangle native symbols (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bucket unknown symbols by PC and demangle native symbols R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31247

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -21 lines)			Patch
M	runtime/vm/native_symbol_linux.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/native_symbol_macos.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/profiler.cc	View	1 2	4 chunks	+36 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/100133004/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/100133004/diff/1/runtime/vm/profiler.cc#newcode227 runtime/vm/profiler.cc:227: static char* FindSymbolName(uintptr_t pc, bool* symbol_name_allocated) { ...

7 years ago (2013-12-19 00:10:09 UTC) #2

Cutch

https://codereview.chromium.org/100133004/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/100133004/diff/1/runtime/vm/profiler.cc#newcode227 runtime/vm/profiler.cc:227: static char* FindSymbolName(uintptr_t pc, bool* symbol_name_allocated) { On 2013/12/19 ...

7 years ago (2013-12-19 00:19:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r31247 (presubmit successful).

Expand Messages | Collapse Messages