Bucket unknown symbols by PC and demangle native symbols

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <cstdio>
 
 #include "platform/utils.h"
 
 #include "vm/atomic.h"
 #include "vm/isolate.h"
@@ skipping 206 matching lines @@
   stackWalker.walk();
 }
 
 
 void Profiler::PrintToJSONStream(Isolate* isolate, JSONStream* stream) {
   ASSERT(isolate == Isolate::Current());
   UNIMPLEMENTED();
 }
 
 
-static char* FindSymbolName(uintptr_t pc, bool* native_symbol) {
+static char* FindSymbolName(uintptr_t pc, bool* symbol_name_allocated) {

[Ivan Posva, 2013/12/19 00:10:10]

"static const char*" should avoid the const_cast below and you really do not
expect anybody to modify the chars within that pointer.

[Cutch, 2013/12/19 00:19:25]

Done.

   // TODO(johnmccutchan): Differentiate between symbols which can't be found
   // and symbols which were GCed. (Heap::CodeContains).
-  ASSERT(native_symbol != NULL);
+  ASSERT(symbol_name_allocated != NULL);
   const char* symbol_name = "Unknown";
-  *native_symbol = false;
+  *symbol_name_allocated = false;
   if (pc == 0) {
     return const_cast<char*>(Sample::kNoFrame);
   }
   const Code& code = Code::Handle(Code::LookupCode(pc));
-  if (code.IsNull()) {
-    // Possibly a native symbol.
-    char* native_name = NativeSymbolResolver::LookupSymbolName(pc);
-    if (native_name != NULL) {
-      symbol_name = native_name;
-      *native_symbol = true;
-    }
-  } else {
+  if (!code.IsNull()) {
     const Function& function = Function::Handle(code.function());
     if (!function.IsNull()) {
       const String& name = String::Handle(function.QualifiedUserVisibleName());
       if (!name.IsNull()) {
         symbol_name = name.ToCString();
+        return const_cast<char*>(symbol_name);
       }
     }
+  } else {
+    // Possibly a native symbol.
+    char* native_name = NativeSymbolResolver::LookupSymbolName(pc);
+    if (native_name != NULL) {
+      symbol_name = native_name;
+      *symbol_name_allocated = true;
+      return const_cast<char*>(symbol_name);
+    }
+  }
+  const intptr_t kBucketSize = 256;
+  const intptr_t kBucketMask = ~(kBucketSize - 1);
+  // Not a Dart symbol or a native symbol. Bin into buckets by PC.
+  pc &= kBucketMask;
+  {
+    const intptr_t kBuffSize = 256;
+    OS::SNPrint(&buff[0], kBuffSize-1, "Unknown [%" Px ", %" Px ")",
+                pc, pc + kBucketSize);
+    symbol_name = strdup(buff);
+    *symbol_name_allocated = true;
   }
   return const_cast<char*>(symbol_name);
 }
 
 
 void Profiler::WriteTracingSample(Isolate* isolate, intptr_t pid,
                                   Sample* sample, JSONArray& events) {
   Sample::SampleType type = sample->type;
   intptr_t tid = Thread::ThreadIdToIntPtr(sample->tid);
   double timestamp = static_cast<double>(sample->timestamp);
@@ skipping 13 matching lines @@
       begin.AddProperty("ph", "E");
       begin.AddProperty("tid", tid);
       begin.AddProperty("pid", pid);
       begin.AddProperty("name", isolate_name);
       begin.AddProperty("ts", timestamp);
     }
     break;
     case Sample::kIsolateSample:
       // Write "B" events.
       for (int i = Sample::kNumStackFrames - 1; i >= 0; i--) {
-        bool native_symbol = false;
-        char* symbol_name = FindSymbolName(sample->pcs[i], &native_symbol);
+        bool symbol_name_allocated = false;
+        char* symbol_name = FindSymbolName(sample->pcs[i],
+                                           &symbol_name_allocated);
         {
           JSONObject begin(&events);
           begin.AddProperty("ph", "B");
           begin.AddProperty("tid", tid);
           begin.AddProperty("pid", pid);
           begin.AddProperty("name", symbol_name);
           begin.AddProperty("ts", timestamp);
         }
-        if (native_symbol) {
-          NativeSymbolResolver::FreeSymbolName(symbol_name);
+        if (symbol_name_allocated) {
+          free(symbol_name);
         }
       }
       // Write "E" events.
       for (int i = 0; i < Sample::kNumStackFrames; i++) {
         bool native_symbol = false;
         char* symbol_name = FindSymbolName(sample->pcs[i], &native_symbol);
         {
           JSONObject begin(&events);
           begin.AddProperty("ph", "E");
           begin.AddProperty("tid", tid);
@@ skipping 227 matching lines @@
     return false;
   }
   uintptr_t cursor = reinterpret_cast<uintptr_t>(fp);
   cursor += sizeof(fp);
   bool r = cursor >= lower_bound_ && cursor < stack_upper_;
   return r;
 }
 
 
 }  // namespace dart