base/threading/worker_pool_posix.h - Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/worker_pool_posix.h

Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: One more base/ change from a different CL Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/synchronization/waitable_event_watcher_posix.cc ('K') | « base/synchronization/waitable_event_watcher_posix.cc ('k') | remoting/base/plugin_message_loop_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/threading/worker_pool_posix.h

diff --git a/base/threading/worker_pool_posix.h b/base/threading/worker_pool_posix.h

index f56582de3b57fd8611a42bdf71a75e109429cd16..eca113a8791cfbaff7ff9730455d5dbceba50096 100644

--- a/base/threading/worker_pool_posix.h

+++ b/base/threading/worker_pool_posix.h

@@ -53,7 +53,6 @@ class BASE_EXPORT PosixDynamicThreadPool

// |idle_seconds_before_exit|.

PosixDynamicThreadPool(const std::string& name_prefix,

int idle_seconds_before_exit);

- ~PosixDynamicThreadPool();

// Indicates that the thread pool is going away. Stops handing out tasks to

// worker threads. Wakes up all the idle threads to let them exit.

@@ -68,8 +67,11 @@ class BASE_EXPORT PosixDynamicThreadPool

PendingTask WaitForTask();

private:

+ friend class RefCountedThreadSafe<PosixDynamicThreadPool>;

friend class PosixDynamicThreadPoolPeer;

+ ~PosixDynamicThreadPool();

// Adds pending_task to the thread pool. This function will clear

// |pending_task->task|.

void AddTask(PendingTask* pending_task);