base/synchronization/waitable_event_watcher_posix.cc - Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/waitable_event_watcher_posix.cc

Issue 9997007: Objects that derive from RefCounted/RefCountedThreadSafe should not have public dtors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: One more base/ change from a different CL Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/waitable_event_watcher_posix.cc

diff --git a/base/synchronization/waitable_event_watcher_posix.cc b/base/synchronization/waitable_event_watcher_posix.cc

index 3b0ba70c22b481891d49dea8b3f9437b0ae17084..147cddacba5e2c0fc93139180ae5c408d55f62cf 100644

--- a/base/synchronization/waitable_event_watcher_posix.cc

+++ b/base/synchronization/waitable_event_watcher_posix.cc

@@ -43,6 +43,9 @@ class Flag : public RefCountedThreadSafe<Flag> {

}

private:

+ friend class RefCountedThreadSafe<Flag>;

+ virtual ~Flag() {}

jar (doing other things) 2012/04/05 23:04:59 Why bother saying virtual here? You didn't bother

mutable Lock lock_;

bool flag_;

};

« no previous file with comments | « base/synchronization/waitable_event.h ('k') | base/threading/worker_pool_posix.h » ('j') | no next file with comments »