Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9980002: Mac content shell: HTTP auth. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Mac content shell: HTTP auth. BUG=120526 TEST=HTTP auth works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130918

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed extraneous forward declare #

Total comments: 6

Patch Set 3 : jam's tweak #

Patch Set 4 : jochen's tweaks #

Patch Set 5 : other platforms #

Patch Set 6 : CreateDialog is a macro on Windows; change it #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+772 lines, -5 lines) Patch
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_login_delegate.h View 1 chunk +6 lines, -4 lines 0 comments Download
A content/shell/mac/English.lproj/HttpAuth.xib View 1 chunk +350 lines, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
A content/shell/shell_login_dialog.h View 1 2 3 4 5 1 chunk +87 lines, -0 lines 0 comments Download
A content/shell/shell_login_dialog.cc View 1 2 3 4 5 1 chunk +107 lines, -0 lines 0 comments Download
A content/shell/shell_login_dialog_mac.mm View 1 2 3 1 chunk +138 lines, -0 lines 0 comments Download
A content/shell/shell_resource_dispatcher_host_delegate.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A content/shell/shell_resource_dispatcher_host_delegate.cc View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Avi (use Gerrit)
Jochen: Mac stuff John: all else Jochen, if you are good reviewing the other code ...
8 years, 8 months ago (2012-04-04 14:32:27 UTC) #1
jam
lgtm http://codereview.chromium.org/9980002/diff/2001/content/shell/shell_resource_dispatcher_host_delegate.h File content/shell/shell_resource_dispatcher_host_delegate.h (right): http://codereview.chromium.org/9980002/diff/2001/content/shell/shell_resource_dispatcher_host_delegate.h#newcode9 content/shell/shell_resource_dispatcher_host_delegate.h:9: #include <vector> nit: not needed
8 years, 8 months ago (2012-04-04 15:37:03 UTC) #2
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/9980002/diff/2001/content/shell/shell_resource_dispatcher_host_delegate.h File content/shell/shell_resource_dispatcher_host_delegate.h (right): https://chromiumcodereview.appspot.com/9980002/diff/2001/content/shell/shell_resource_dispatcher_host_delegate.h#newcode9 content/shell/shell_resource_dispatcher_host_delegate.h:9: #include <vector> On 2012/04/04 15:37:03, John Abd-El-Malek wrote: > ...
8 years, 8 months ago (2012-04-04 15:41:39 UTC) #3
jochen (gone - plz use gerrit)
lgtm with nits https://chromiumcodereview.appspot.com/9980002/diff/2001/content/shell/shell_login_dialog.cc File content/shell/shell_login_dialog.cc (right): https://chromiumcodereview.appspot.com/9980002/diff/2001/content/shell/shell_login_dialog.cc#newcode19 content/shell/shell_login_dialog.cc:19: net::URLRequest* request) : auth_info_(auth_info), Align parameters ...
8 years, 8 months ago (2012-04-04 15:46:56 UTC) #4
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/9980002/diff/2001/content/shell/shell_login_dialog.cc File content/shell/shell_login_dialog.cc (right): https://chromiumcodereview.appspot.com/9980002/diff/2001/content/shell/shell_login_dialog.cc#newcode19 content/shell/shell_login_dialog.cc:19: net::URLRequest* request) : auth_info_(auth_info), On 2012/04/04 15:46:56, jochen wrote: ...
8 years, 8 months ago (2012-04-04 16:18:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9980002/4002
8 years, 8 months ago (2012-04-04 16:18:26 UTC) #6
commit-bot: I haz the power
Try job failure for 9980002-4002 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-04 17:01:29 UTC) #7
Avi (use Gerrit)
Oops, forgot other platforms. This should work, trying now.
8 years, 8 months ago (2012-04-04 17:36:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9980002/40
8 years, 8 months ago (2012-04-04 20:52:51 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-05 01:11:41 UTC) #10 
Try job failure for 9980002-40 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698