Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/sync/glue/data_type_error_handler.h

Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/data_type_error_handler.h
diff --git a/chrome/browser/sync/glue/data_type_error_handler.h b/chrome/browser/sync/glue/data_type_error_handler.h
index 06821e76f54907d3d8003b013dca0472683cea62..5334d98cb042f146a54d4fa0841aceb1ed34b01f 100644
--- a/chrome/browser/sync/glue/data_type_error_handler.h
+++ b/chrome/browser/sync/glue/data_type_error_handler.h
@@ -8,7 +8,10 @@
#include <string>
#include "base/location.h"
+
+#include "chrome/browser/sync/api/sync_error.h"
#include "sync/util/unrecoverable_error_handler.h"
+#include "sync/syncable/model_type.h"
namespace browser_sync {
@@ -19,6 +22,15 @@ class DataTypeErrorHandler : public UnrecoverableErrorHandler {
virtual void OnSingleDatatypeUnrecoverableError(
const tracked_objects::Location& from_here,
const std::string& message) = 0;
+
+ // This will create a SyncError object. This will also upload
+ // a breakpad call stack to crash server. A sync error usually means
+ // that sync has to be disabled either for that type or completely.
+ virtual SyncError CreateAndUploadError(
+ const tracked_objects::Location& location,
+ const std::string& message,
+ syncable::ModelType type) = 0;
+
protected:
virtual ~DataTypeErrorHandler() { }
};
« no previous file with comments | « chrome/browser/sync/glue/data_type_controller.cc ('k') | chrome/browser/sync/glue/data_type_error_handler_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698