Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: chrome/browser/sync/glue/data_type_controller.cc

Issue 9978017: [Sync] - Upload the callstacks for errors so that the line number of error is in callstack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/data_type_controller.h ('k') | chrome/browser/sync/glue/data_type_error_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/data_type_controller.cc
diff --git a/chrome/browser/sync/glue/data_type_controller.cc b/chrome/browser/sync/glue/data_type_controller.cc
index 0eb5ec6f343ab7ef689178ede0145576d11abb1f..9014ece073505d048dc423f2c6edeb8520448256 100644
--- a/chrome/browser/sync/glue/data_type_controller.cc
+++ b/chrome/browser/sync/glue/data_type_controller.cc
@@ -10,7 +10,7 @@
namespace browser_sync {
bool DataTypeController::IsUnrecoverableResult(StartResult result) {
- return (result == ASSOCIATION_FAILED || result == UNRECOVERABLE_ERROR);
+ return (result == UNRECOVERABLE_ERROR);
}
void DataTypeController::RecordUnrecoverableError(
@@ -25,4 +25,12 @@ void DataTypeController::RecordUnrecoverableError(
ChromeReportUnrecoverableError();
}
+SyncError DataTypeController::CreateAndUploadError(
+ const tracked_objects::Location& location,
+ const std::string& message,
+ syncable::ModelType type) {
+ ChromeReportUnrecoverableError();
+ return SyncError(location, message, type);
}
+
+} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/data_type_controller.h ('k') | chrome/browser/sync/glue/data_type_error_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698