Change the "close Chrome with downloads in progress" dialog to resemble kenmoore's mock

chrome/browser/ui/views/download/download_in_progress_dialog_view.h

Index: chrome/browser/ui/views/download/download_in_progress_dialog_view.h
diff --git a/chrome/browser/ui/views/download/download_in_progress_dialog_view.h b/chrome/browser/ui/views/download/download_in_progress_dialog_view.h
index 0540d7dcdbfd050b600ad29845cf390d8d338ca8..8b7960d69ac301963f4f8d0ca40604f10c2fc191 100644
--- a/chrome/browser/ui/views/download/download_in_progress_dialog_view.h
+++ b/chrome/browser/ui/views/download/download_in_progress_dialog_view.h
@@ -13,10 +13,10 @@
 class Browser;
 
 namespace views {
-class Label;
+class MessageBoxView;
 }
 
-class DownloadInProgressDialogView : public views::DialogDelegateView {
+class DownloadInProgressDialogView : public views::DialogDelegate {

[benrg, 2012/04/17 01:32:44]

Should this be in the views namespace?

Should I rename this class to "DownloadInProgressDialog" since it's no longer a
View?

[James Cook, 2012/04/17 19:03:21]

I don't think it should be in the views namespace.  I believe the views
namespace is used for the implementation of views (hence views::Label,
views::Button, etc.) but not for users of views.  We do a similar thing with
test utilities - test utils are often in a test:: namespace, but that doesn't
mean every test is in that namespace.

Since it is no longer a view, I think renaming the file and class is a good
idea.

[benrg, 2012/04/17 20:39:14]

On second thought the View suffix may just mean "the views implementation of
this dialog". DownloadShelfContextMenuView is a DownloadShelfContextMenu but not
a View. Ben G, what should I do?

  public:
   static void Show(Browser* browser, gfx::NativeWindow parent_window);
 
@@ -24,22 +24,24 @@ class DownloadInProgressDialogView : public views::DialogDelegateView {
   explicit DownloadInProgressDialogView(Browser* browser);
   virtual ~DownloadInProgressDialogView();
 
-  // views::View:
-  virtual gfx::Size GetPreferredSize() OVERRIDE;
-
-  // views::DialogDelegateView:
-  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
+  // views::DialogDelegate:
   virtual int GetDefaultDialogButton() const OVERRIDE;
+  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
   virtual bool Cancel() OVERRIDE;
   virtual bool Accept() OVERRIDE;
+
+  // views::WidgetDelegate:
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual string16 GetWindowTitle() const OVERRIDE;
+  virtual void DeleteDelegate() OVERRIDE;
+  virtual views::Widget* GetWidget() OVERRIDE;
+  virtual const views::Widget* GetWidget() const OVERRIDE;
   virtual views::View* GetContentsView() OVERRIDE;
 
   Browser* browser_;
-  views::Label* warning_;
-  views::Label* explanation_;
+  views::MessageBoxView* message_box_view_;
 
+  string16 title_text_;
   string16 ok_button_text_;
   string16 cancel_button_text_;