Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: ash/wm/workspace/workspace_manager.cc

Issue 9969164: Ignoring alignment when it pushes a window out of the screen (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moving align to grid functionality into WindowPositioner / WindowSizer Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/workspace_manager.cc
diff --git a/ash/wm/workspace/workspace_manager.cc b/ash/wm/workspace/workspace_manager.cc
index 05ab750817c1ef223079375ff576e873419e40ae..856c22890a477fe7b8771c99f206768c7f11aa4d 100644
--- a/ash/wm/workspace/workspace_manager.cc
+++ b/ash/wm/workspace/workspace_manager.cc
@@ -43,15 +43,6 @@ void BuildWindowList(const std::vector<aura::Window*>& windows,
}
}
-gfx::Rect AlignRectToGrid(const gfx::Rect& rect, int grid_size) {
- if (grid_size <= 1)
- return rect;
- return gfx::Rect(ash::WindowResizer::AlignToGrid(rect.x(), grid_size),
- ash::WindowResizer::AlignToGrid(rect.y(), grid_size),
- ash::WindowResizer::AlignToGrid(rect.width(), grid_size),
- ash::WindowResizer::AlignToGrid(rect.height(), grid_size));
-}
-
}
namespace ash {
@@ -105,9 +96,6 @@ void WorkspaceManager::AddWindow(aura::Window* window) {
return;
}
- if (wm::IsWindowNormal(window) && grid_size_ > 1)
- SetWindowBounds(window, AlignBoundsToGrid(window->GetTargetBounds()));
-
Workspace* workspace = NULL;
Workspace::Type type_for_window = Workspace::TypeForWindow(window);
switch (type_for_window) {
@@ -143,12 +131,6 @@ void WorkspaceManager::SetActiveWorkspaceByWindow(aura::Window* window) {
workspace->Activate();
}
-gfx::Rect WorkspaceManager::AlignBoundsToGrid(const gfx::Rect& bounds) {
- if (grid_size_ <= 1)
- return bounds;
- return AlignRectToGrid(bounds, grid_size_);
-}
-
void WorkspaceManager::UpdateShelfVisibility() {
shelf_->UpdateVisibilityState();
}

Powered by Google App Engine
This is Rietveld 408576698