Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 9969111: Adds qcms to third_party for use in handling ICC color profiles. (Closed)

Created:
8 years, 8 months ago by tpayne
Modified:
8 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@bug143
Visibility:
Public.

Description

Adds qcms to third_party for use in handling ICC color profiles. BUG=143 TEST=None

Patch Set 1 #

Patch Set 2 : Removed unused Makefile.in #

Patch Set 3 : Change to using DEPS to pull in qcms #

Patch Set 4 : Fix qcms src location #

Patch Set 5 : Update license file location #

Total comments: 1

Patch Set 6 : Added qcms back to third_party #

Patch Set 7 : Moved downloaded src to third_party/qcms/src #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5478 lines, -0 lines) Patch
A third_party/qcms/README.chromium View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/qcms/qcms.gyp View 1 2 6 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/qcms/src/COPYING View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/qcms/src/README View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/qcms/src/chain.h View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/qcms/src/chain.c View 1 2 3 4 5 6 1 chunk +989 lines, -0 lines 0 comments Download
A third_party/qcms/src/iccread.c View 1 2 3 4 5 6 1 chunk +1204 lines, -0 lines 0 comments Download
A third_party/qcms/src/matrix.h View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/qcms/src/matrix.c View 1 2 3 4 5 6 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcms.h View 1 2 3 4 5 6 1 chunk +156 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcmsint.h View 1 2 3 4 5 6 1 chunk +297 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcmstypes.h View 1 2 3 4 5 6 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform.c View 1 2 3 4 5 6 1 chunk +1272 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform-sse1.c View 1 2 3 4 5 6 1 chunk +274 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform-sse2.c View 1 2 3 4 5 6 1 chunk +262 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform_util.h View 1 2 3 4 5 6 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform_util.c View 1 2 3 4 5 6 1 chunk +559 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tpayne
8 years, 8 months ago (2012-04-03 18:54:07 UTC) #1
Evan Stade
aside from the comment, lg http://codereview.chromium.org/9969111/diff/6001/DEPS File DEPS (right): http://codereview.chromium.org/9969111/diff/6001/DEPS#newcode298 DEPS:298: "https://github.com/jrmuizel/qcms.git@7ee04f093a", since this is ...
8 years, 8 months ago (2012-04-03 19:19:35 UTC) #2
Evan Stade
lgtm
8 years, 8 months ago (2012-04-03 21:45:16 UTC) #3
Evan Stade
sorry, nevermind. Should be dropping straight into third_party like in patchset 1. I would prefer ...
8 years, 8 months ago (2012-04-03 21:46:36 UTC) #4
tpayne
On 2012/04/03 21:46:36, Evan Stade wrote: > sorry, nevermind. Should be dropping straight into third_party ...
8 years, 8 months ago (2012-04-03 21:50:03 UTC) #5
Evan Stade
8 years, 8 months ago (2012-04-03 22:41:14 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698