Switch platform apps from a declarative launch container to handling an onLaunched event.

chrome/browser/extensions/extension_tabs_module.cc

Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index ef450fdec583db4284b61d6b5b19149618a86ba9..a89d20daaa23d22ca7f96918d2fa4014a1039fff 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -58,6 +58,7 @@
 #include "content/public/browser/render_view_host_delegate.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
+#include "content/public/common/url_constants.h"
 #include "skia/ext/image_operations.h"
 #include "skia/ext/platform_canvas.h"
 #include "third_party/skia/include/core/SkBitmap.h"
@@ -460,7 +461,7 @@ bool CreateWindowFunction::RunImpl() {
   }
 
   // Try to position the new browser relative its originating browser window.
-  gfx::Rect  window_bounds;
+  gfx::Rect window_bounds;
   // The call offsets the bounds by kWindowTilePixels (defined in WindowSizer to
   // be 10)
   //
@@ -565,10 +566,12 @@ bool CreateWindowFunction::RunImpl() {
           window_type = Browser::TYPE_POPUP;
       } else if (type_str == keys::kWindowTypeValueShell &&
           GetExtension()->is_platform_app()) {
-        GURL window_url =
-            urls.empty() ? GetExtension()->GetFullLaunchURL() : urls[0];
+        GURL window_url = urls.empty() ? GURL(chrome::kAboutBlankURL) : urls[0];
         ShellWindow* shell_window =
             ShellWindow::Create(window_profile, GetExtension(), window_url);
+        // TODO(mihaip): It might be less janky to pass in the desired bounds

[Mihai Parparita -not on Chrome, 2012/04/05 02:28:13]

Something like Aaron's Browser::CreateWithParams refactoring from
http://crrev.com/130696 would be ideal (then additional constraints, like
min/max size, which I temporarily ripped out, could be passed in). However, this
CL is big enough as it is, so I'll doing that in a follow up CL.

+        // into ShellWindow::Create directly.
+        shell_window->SetBounds(window_bounds);
         result_.reset(shell_window->extension_window_controller()->
             CreateWindowValueWithTabs());
         return true;