Switch platform apps from a declarative launch container to handling an onLaunched event.

chrome/browser/extensions/extension_tabs_module.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tabs_module.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 40 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_view_host_delegate.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
+#include "content/public/common/url_constants.h"
 #include "skia/ext/image_operations.h"
 #include "skia/ext/platform_canvas.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/ui_base_types.h"
 #include "ui/gfx/codec/jpeg_codec.h"
 #include "ui/gfx/codec/png_codec.h"
 
 #if defined(USE_ASH)
 #include "ash/ash_switches.h"
 #include "base/command_line.h"
@@ skipping 382 matching lines @@
       contents = source_tab_strip->DetachTabContentsAt(tab_index);
       if (!contents) {
         error_ = ExtensionErrorUtils::FormatErrorMessage(
             keys::kTabNotFoundError, base::IntToString(tab_id));
         return false;
       }
     }
   }
 
   // Try to position the new browser relative its originating browser window.
-  gfx::Rect  window_bounds;
+  gfx::Rect window_bounds;
   // The call offsets the bounds by kWindowTilePixels (defined in WindowSizer to
   // be 10)
   //
   // NOTE(rafaelw): It's ok if GetCurrentBrowser() returns NULL here.
   // GetBrowserWindowBounds will default to saved "default" values for the app.
   WindowSizer::GetBrowserWindowBounds(std::string(), gfx::Rect(),
                                       GetCurrentBrowser(), &window_bounds);
 
   // Calculate popup and panels bounds separately.
   gfx::Rect popup_bounds;
@@ skipping 84 matching lines @@
         if (CommandLine::ForCurrentProcess()->HasSwitch(
                 ash::switches::kAuraPanelManager))
           use_panels = true;
 #endif
         if (use_panels)
           window_type = Browser::TYPE_PANEL;
         else
           window_type = Browser::TYPE_POPUP;
       } else if (type_str == keys::kWindowTypeValueShell &&
           GetExtension()->is_platform_app()) {
-        GURL window_url =
-            urls.empty() ? GetExtension()->GetFullLaunchURL() : urls[0];
+        GURL window_url = urls.empty() ? GURL(chrome::kAboutBlankURL) : urls[0];
         ShellWindow* shell_window =
             ShellWindow::Create(window_profile, GetExtension(), window_url);
+        // TODO(mihaip): It might be less janky to pass in the desired bounds

[Mihai Parparita -not on Chrome, 2012/04/05 02:28:13]

Something like Aaron's Browser::CreateWithParams refactoring from
http://crrev.com/130696 would be ideal (then additional constraints, like
min/max size, which I temporarily ripped out, could be passed in). However, this
CL is big enough as it is, so I'll doing that in a follow up CL.

+        // into ShellWindow::Create directly.
+        shell_window->SetBounds(window_bounds);
         result_.reset(shell_window->extension_window_controller()->
             CreateWindowValueWithTabs());
         return true;
       } else if (type_str != keys::kWindowTypeValueNormal) {
         error_ = keys::kInvalidWindowTypeError;
         return false;
       }
     }
   }
 
@@ skipping 1240 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   result_.reset(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }