Issue 9969025: Fix compile warnings in Panel.xib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9969025: Fix compile warnings in Panel.xib (Closed)

Created:
8 years, 8 months ago by Dmitry Titov

Modified:
8 years, 8 months ago

Reviewers:
Nico, dcheng

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix compile warnings in Panel.xib XIB changes: - removed "Single Line" attribute from NSTextField (we don't need it since we set NSTextField to Layout:Truncate, LineBreaks:TruncateTail in IB so it does not wrap/scroll) - removed obsolete outlets that do not exist in the code - removed autosizing masks for controls we layout from code anyways Moved PanelWindowCocoaImpl declaration into .h file so the IB can see it. The XIB now compiles w/o warnings and the layout code is more consistent (all controls are laid out in the similar way in code) BUG=120539 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130457

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -54 lines)			Patch
M	chrome/app/nibs/Panel.xib	View	1 2	11 chunks	+60 lines, -39 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm	View	1 2 3	5 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_window_controller_cocoa.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_window_controller_cocoa.mm	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/9969025/6001

8 years, 8 months ago (2012-04-03 18:21:51 UTC) #3

That's neck-to-neck race! :-)

Expand Messages | Collapse Messages

Issue 9969025: Fix compile warnings in Panel.xib (Closed)

Description

Patch Set 1 #

Patch Set 2 : moved interface declaration into .h file so IB can see it #

Patch Set 3 : more cleanup #

Patch Set 4 : patch for landing #

Messages