Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.h

Issue 9969025: Fix compile warnings in Panel.xib (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_window_controller_cocoa.h
diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.h b/chrome/browser/ui/panels/panel_window_controller_cocoa.h
index e8264077eccd21582a7f4a1612649813b5a2bc2f..fd5145153a978399f96cc3321f39187df46df3d1 100644
--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.h
+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.h
@@ -26,6 +26,20 @@
class PanelBrowserWindowCocoa;
@class PanelTitlebarViewCocoa;
+@interface PanelWindowCocoaImpl : ChromeBrowserWindow {
+ // Panel windows use a higher priority NSWindowLevel to ensure they are always
+ // visible, causing the OS to prefer panel windows when selecting a window
+ // to make the key window. To counter this preference, we override
+ // -[NSWindow:canBecomeKeyWindow] to restrict when the panel can become the
+ // key window to a limited set of scenarios, such as when cycling through
+ // windows, when panels are the only remaining windows, when an event
+ // triggers window activation, etc. The panel may also be prevented from
+ // becoming the key window, regardless of the above scenarios, such as when
+ // a panel is minimized.
+ BOOL canBecomeKey_; // Defaults to NO.
+}
+@end
+
@interface PanelWindowControllerCocoa : NSWindowController
<NSWindowDelegate,
NSAnimationDelegate,
« no previous file with comments | « chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698