Issue 9965119: Reduce duplication in third_party/zlib/zlib.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9965119: Reduce duplication in third_party/zlib/zlib.gyp. (Closed)

Created:
8 years, 8 months ago by Nico

Modified:
8 years, 8 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Reduce duplication in third_party/zlib/zlib.gyp. Also, move the clang warning flags to the block that's shared for system / nonsystem zlib use. BUG=none TEST=fewer warnings when building with clang on linux NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130459

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -42 lines)			Patch
	M	third_party/zlib/zlib.gyp	View		4 chunks	+28 lines, -42 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9965119/1

8 years, 8 months ago (2012-04-03 21:06:13 UTC) #3

Change committed as 130459

Expand Messages | Collapse Messages