Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: third_party/zlib/zlib.gyp

Issue 9965119: Reduce duplication in third_party/zlib/zlib.gyp. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/zlib.gyp
diff --git a/third_party/zlib/zlib.gyp b/third_party/zlib/zlib.gyp
index 7e161da45b0361597bce23c3cd2ab137ee68321f..8b10ff18b1025545fd3fb9c1be0b7eb54c866426 100644
--- a/third_party/zlib/zlib.gyp
+++ b/third_party/zlib/zlib.gyp
@@ -15,12 +15,12 @@
}],
],
},
- 'conditions': [
- ['use_system_zlib==0', {
- 'targets': [
- {
- 'target_name': 'zlib',
- 'type': 'static_library',
+ 'targets': [
+ {
+ 'target_name': 'zlib',
+ 'type': 'static_library',
+ 'conditions': [
+ ['use_system_zlib==0', {
'sources': [
'contrib/minizip/ioapi.c',
'contrib/minizip/ioapi.h',
@@ -71,33 +71,8 @@
'contrib/minizip/iowin32.c'
],
}],
- ['OS=="mac" or os_bsd==1 or OS=="android"', {
- # Mac, Android and the BSDs don't have fopen64, ftello64, or
- # fseeko64. We use fopen, ftell, and fseek instead on these
- # systems.
- 'defines': [
- 'USE_FILE32API'
- ],
- }],
- ['clang==1', {
- 'xcode_settings': {
- 'WARNING_CFLAGS': [
- # zlib uses `if ((a == b))` for some reason.
- '-Wno-parentheses-equality',
- ],
- },
- 'cflags': [
- '-Wno-parentheses-equality',
- ],
- }],
],
- },
- ],
- }, {
- 'targets': [
- {
- 'target_name': 'zlib',
- 'type': 'static_library',
+ }, {
'direct_dependent_settings': {
'defines': [
'USE_SYSTEM_ZLIB',
@@ -115,14 +90,6 @@
'contrib/minizip/zip.h',
],
'conditions': [
- ['OS=="mac" or os_bsd==1 or OS=="android"', {
- # Mac, Android and the BSDs don't have fopen64, ftello64, or
- # fseeko64. We use fopen, ftell, and fseek instead on these
- # systems.
- 'defines': [
- 'USE_FILE32API'
- ],
- }],
['OS=="android"', {
'toolsets': ['target', 'host'],
}],
@@ -132,8 +99,27 @@
'-lz',
],
},
- },
+ }],
+ ['OS=="mac" or os_bsd==1 or OS=="android"', {
+ # Mac, Android and the BSDs don't have fopen64, ftello64, or
+ # fseeko64. We use fopen, ftell, and fseek instead on these
+ # systems.
+ 'defines': [
+ 'USE_FILE32API'
+ ],
+ }],
+ ['clang==1', {
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': [
+ # zlib uses `if ((a == b))` for some reason.
+ '-Wno-parentheses-equality',
+ ],
+ },
+ 'cflags': [
+ '-Wno-parentheses-equality',
+ ],
+ }],
],
- }],
+ }
],
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698