Restore tray background when locking screen.

Restore tray background when locking screen.

BUG=121230
TEST=Move window to overlap ash shelf such that the shelf background is visible. Lock screen, system tray background should become visible when locked and invisible (to blend in with shelf) when unlocked.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130316

[flackr, 2012-04-02 18:32:24]

This tracks lock state in ShelfLayoutManager since we have to update the tray
background visibility based on it. PTAL, thanks.

[flackr, 2012-04-02 18:58:21]

-ben +sky
Seems like sky would be more familiar with this code. PTAL, thanks!

[sky, 2012-04-02 21:08:14]

LGTM with the following changes.

http://codereview.chromium.org/9965070/diff/1/ash/wm/shelf_layout_manager.h
File ash/wm/shelf_layout_manager.h (right):

http://codereview.chromium.org/9965070/diff/1/ash/wm/shelf_layout_manager.h#n...
ash/wm/shelf_layout_manager.h:153: State() : visibility_state(VISIBLE),
auto_hide_state(AUTO_HIDE_HIDDEN),
when you can't fit all the members on a single line, wrap each member onto its
own line.

http://codereview.chromium.org/9965070/diff/1/ash/wm/shelf_layout_manager.h#n...
ash/wm/shelf_layout_manager.h:168: bool locked_state;
locked_state -> is_screen_locked

[flackr, 2012-04-02 23:12:46]

http://codereview.chromium.org/9965070/diff/1/ash/wm/shelf_layout_manager.h
File ash/wm/shelf_layout_manager.h (right):

http://codereview.chromium.org/9965070/diff/1/ash/wm/shelf_layout_manager.h#n...
ash/wm/shelf_layout_manager.h:153: State() : visibility_state(VISIBLE),
auto_hide_state(AUTO_HIDE_HIDDEN),
On 2012/04/02 21:08:14, sky wrote:
> when you can't fit all the members on a single line, wrap each member onto its
> own line.

Done.

http://codereview.chromium.org/9965070/diff/1/ash/wm/shelf_layout_manager.h#n...
ash/wm/shelf_layout_manager.h:168: bool locked_state;
On 2012/04/02 21:08:14, sky wrote:
> locked_state -> is_screen_locked

Done.

[commit-bot: I haz the power, 2012-04-02 23:34:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/9965070/4001

[commit-bot: I haz the power, 2012-04-03 04:57:17]

Change committed as 130316