Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 9963028: Revert blocking of file: downloads. (Closed)

Created:
8 years, 8 months ago by Randy Smith (Not in Mondays)
Modified:
8 years, 8 months ago
Reviewers:
chebert
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Nirnimesh, jam, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Revert blocking of file: downloads. BUG=120280 BUG=120604 BUG=119129 TEST=Manually drag an extension into the browser; it should try to install. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130191

Patch Set 1 #

Patch Set 2 : Re-enabled pyauto tests. #

Patch Set 3 : Fixed api tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -84 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 chunk +44 lines, -52 lines 0 comments Download
M chrome/test/data/extensions/api_test/downloads/test.js View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 3 chunks +0 lines, -27 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
chebert
lgtm
8 years, 8 months ago (2012-03-30 20:52:46 UTC) #1
Aaron Boodman
I don't think chebert can lgtm yet, not a committer.
8 years, 8 months ago (2012-03-30 20:56:40 UTC) #2
Randy Smith (Not in Mondays)
On 2012/03/30 20:56:40, Aaron Boodman wrote: > I don't think chebert can lgtm yet, not ...
8 years, 8 months ago (2012-03-30 20:59:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/9963028/3005
8 years, 8 months ago (2012-03-31 23:26:50 UTC) #4
commit-bot: I haz the power
Try job failure for 9963028-3005 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-01 02:56:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/9963028/3005
8 years, 8 months ago (2012-04-02 13:36:19 UTC) #6
commit-bot: I haz the power
Try job failure for 9963028-3005 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-02 16:40:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/9963028/3005
8 years, 8 months ago (2012-04-02 17:04:33 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-02 20:21:22 UTC) #9
Change committed as 130191

Powered by Google App Engine
This is Rietveld 408576698