Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 9960072: Upstream crash changes for android. (Closed)

Created:
8 years, 8 months ago by carlosvaldivia
Modified:
8 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Upstream crash changes for android. Third time is a charm. Original Reviews: https://chromiumcodereview.appspot.com/9838033/ http://codereview.chromium.org/9967017 Revert "Revert 131593" This reverts commit e306ea7f630d4264075913ea3a1a728d98ca9605. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131662

Patch Set 1 #

Patch Set 2 : Fixes to gyp and a typo in breakpad_linuxish.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+610 lines, -1879 lines) Patch
A base/android/build_info.h View 1 chunk +88 lines, -0 lines 0 comments Download
A base/android/build_info.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A base/android/java/org/chromium/base/BuildInfo.java View 1 chunk +88 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M breakpad/breakpad.gyp View 1 4 chunks +162 lines, -1 line 0 comments Download
M build/filename_rules.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/app/breakpad_linux.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/app/breakpad_linux.cc View 1 chunk +0 lines, -1038 lines 0 comments Download
A + chrome/app/breakpad_linuxish.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/app/breakpad_linuxish.cc View 1 23 chunks +148 lines, -17 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/crash_handler_host_linux.h View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/crash_handler_host_linux.cc View 1 chunk +0 lines, -484 lines 0 comments Download
D chrome/browser/crash_handler_host_linux_stub.cc View 1 chunk +0 lines, -82 lines 0 comments Download
A + chrome/browser/crash_handler_host_linuxish.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/crash_handler_host_linuxish.cc View 4 chunks +14 lines, -3 lines 0 comments Download
A + chrome/browser/crash_handler_host_linuxish_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/logging_chrome_uitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
carlosvaldivia
Rolled back need owners reviews. Working with Lei to get breakpad.gyp right.
8 years, 8 months ago (2012-04-10 19:21:18 UTC) #1
carlosvaldivia
Peter: can I get an OWNERS lg for: chrome/ui/gtk change.
8 years, 8 months ago (2012-04-10 19:22:02 UTC) #2
carlosvaldivia
Mark, Can get another LG from you while I work through this with Lei?
8 years, 8 months ago (2012-04-10 19:22:31 UTC) #3
Mark Mentovai
LGTM. It’s OK to use TBR for emergency backouts.
8 years, 8 months ago (2012-04-10 19:44:56 UTC) #4
Peter Kasting
LGTM
8 years, 8 months ago (2012-04-10 20:02:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/carlosvaldivia@google.com/9960072/1027
8 years, 8 months ago (2012-04-10 20:10:22 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 22:52:47 UTC) #7
Change committed as 131662

Powered by Google App Engine
This is Rietveld 408576698