Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 9967017: Upstream Android native crash handling changes. (Closed)

Created:
8 years, 8 months ago by carlosvaldivia
Modified:
8 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Upstream Android native crash handling changes. This is actulaly the second time. Revert "Revert 131404 - Upstream native crash handling changes for Android." This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba. Conflicts: chrome/browser/chrome_browser_main.cc BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131593

Patch Set 1 #

Patch Set 2 : Fixes related to changes to breakpad_posix.h #

Total comments: 30

Patch Set 3 : Sync #

Patch Set 4 : sync again #

Total comments: 5

Patch Set 5 : Yet another sync #

Patch Set 6 : Responses to Lei's comments #

Patch Set 7 : Yet another sync before I retry bots #

Total comments: 4

Patch Set 8 : Final Sync and clean up of build_info.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+598 lines, -1879 lines) Patch
A base/android/build_info.h View 1 2 3 4 5 1 chunk +88 lines, -0 lines 0 comments Download
A base/android/build_info.cc View 1 2 3 4 5 6 7 1 chunk +66 lines, -0 lines 0 comments Download
A base/android/java/org/chromium/base/BuildInfo.java View 1 chunk +88 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M breakpad/breakpad.gyp View 1 2 3 4 5 3 chunks +150 lines, -1 line 0 comments Download
M build/filename_rules.gypi View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/app/breakpad_linux.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/app/breakpad_linux.cc View 1 chunk +0 lines, -1038 lines 0 comments Download
A + chrome/app/breakpad_linuxish.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/app/breakpad_linuxish.cc View 1 2 3 4 5 23 chunks +148 lines, -17 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/crash_handler_host_linux.h View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/crash_handler_host_linux.cc View 1 chunk +0 lines, -484 lines 0 comments Download
D chrome/browser/crash_handler_host_linux_stub.cc View 1 chunk +0 lines, -82 lines 0 comments Download
A + chrome/browser/crash_handler_host_linuxish.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/crash_handler_host_linuxish.cc View 1 2 3 4 5 4 chunks +14 lines, -3 lines 0 comments Download
A + chrome/browser/crash_handler_host_linuxish_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/logging_chrome_uitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
(still looking) Can you refer to http://codereview.chromium.org/9838033/ in the CL description? https://chromiumcodereview.appspot.com/9967017/diff/1026/chrome/app/breakpad_linuxish.cc File chrome/app/breakpad_linuxish.cc (right): ...
8 years, 8 months ago (2012-04-09 22:26:54 UTC) #1
Peter Kasting
chroem/browser/ui/gtk OWNERS LGTM
8 years, 8 months ago (2012-04-09 22:39:04 UTC) #2
Lei Zhang
https://chromiumcodereview.appspot.com/9967017/diff/1026/base/android/build_info.cc File base/android/build_info.cc (right): https://chromiumcodereview.appspot.com/9967017/diff/1026/base/android/build_info.cc#newcode6 base/android/build_info.cc:6: nit: I think you forgot to add <string.h> for ...
8 years, 8 months ago (2012-04-09 22:54:57 UTC) #3
Mark Mentovai
Please carefully check your change to ensure that no unrelated pieces have migrated in. I ...
8 years, 8 months ago (2012-04-09 22:55:58 UTC) #4
Mark Mentovai
8 years, 8 months ago (2012-04-09 22:56:33 UTC) #5
carlosvaldivia
I suspect part of the problem is that I keep syncing which brings in synced ...
8 years, 8 months ago (2012-04-09 23:01:01 UTC) #6
carlosvaldivia
https://chromiumcodereview.appspot.com/9967017/diff/1026/base/android/build_info.cc File base/android/build_info.cc (right): https://chromiumcodereview.appspot.com/9967017/diff/1026/base/android/build_info.cc#newcode6 base/android/build_info.cc:6: This works on android. On 2012/04/09 22:54:58, Lei Zhang ...
8 years, 8 months ago (2012-04-09 23:36:23 UTC) #7
Lei Zhang
LGTM per gchat conversation, we'll land this and I'll work on the remaining issues that ...
8 years, 8 months ago (2012-04-09 23:38:39 UTC) #8
carlosvaldivia
On 2012/04/09 22:55:58, Mark Mentovai wrote: > Please carefully check your change to ensure that ...
8 years, 8 months ago (2012-04-09 23:41:23 UTC) #9
Mark Mentovai
LGTM https://chromiumcodereview.appspot.com/9967017/diff/1072/base/android/build_info.cc File base/android/build_info.cc (right): https://chromiumcodereview.appspot.com/9967017/diff/1072/base/android/build_info.cc#newcode20 base/android/build_info.cc:20: It’s abnormal to start a function with a ...
8 years, 8 months ago (2012-04-10 16:53:19 UTC) #10
carlosvaldivia
Thanks. I'm going to try to submit. https://chromiumcodereview.appspot.com/9967017/diff/1072/base/android/build_info.cc File base/android/build_info.cc (right): https://chromiumcodereview.appspot.com/9967017/diff/1072/base/android/build_info.cc#newcode20 base/android/build_info.cc:20: On 2012/04/10 ...
8 years, 8 months ago (2012-04-10 16:59:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/carlosvaldivia@google.com/9967017/2016
8 years, 8 months ago (2012-04-10 17:00:20 UTC) #12
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 18:34:47 UTC) #13
Change committed as 131593

Powered by Google App Engine
This is Rietveld 408576698