Issue 996004: Take ARM big-endian floating point numbers into account in FastD2UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 996004: Take ARM big-endian floating point numbers into account in FastD2UI. (Closed)

Created:
10 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Take ARM big-endian floating point numbers into account in FastD2UI.

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/conversions-inl.h	View		2 chunks	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 9 months ago (2010-03-16 12:12:15 UTC) #2

LGTM

http://codereview.chromium.org/996004/diff/1/2
File src/conversions-inl.h (right):

http://codereview.chromium.org/996004/diff/1/2#newcode87
src/conversions-inl.h:87: memcpy(&result, mantissa_ptr, sizeof(result));  //
Copy low 32 bits.
Comment is out of date!

Expand Messages | Collapse Messages