Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/conversions-inl.h

Issue 996004: Take ARM big-endian floating point numbers into account in FastD2UI. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 // towards zero is implied by the C standard. This means that the 53 // towards zero is implied by the C standard. This means that the
54 // status register of the FPU has to be changed with the 'fldcw' 54 // status register of the FPU has to be changed with the 'fldcw'
55 // instruction. This completely stalls the pipeline and takes many 55 // instruction. This completely stalls the pipeline and takes many
56 // hundreds of clock cycles. 56 // hundreds of clock cycles.
57 return static_cast<int>(x); 57 return static_cast<int>(x);
58 #endif 58 #endif
59 } 59 }
60 60
61 61
62 // The fast double-to-unsigned-int conversion routine does not guarantee 62 // The fast double-to-unsigned-int conversion routine does not guarantee
63 // rounding towards zero. 63 // rounding towards zero, or any reasonable value if the argument is larger
64 // than what fits in an unsigned 32-bit integer.
64 static inline unsigned int FastD2UI(double x) { 65 static inline unsigned int FastD2UI(double x) {
65 // There is no unsigned version of lrint, so there is no fast path 66 // There is no unsigned version of lrint, so there is no fast path
66 // in this function as there is in FastD2I. Using lrint doesn't work 67 // in this function as there is in FastD2I. Using lrint doesn't work
67 // for values of 2^31 and above. 68 // for values of 2^31 and above.
68 69
69 // Convert "small enough" doubles to uint32_t by fixing the 32 70 // Convert "small enough" doubles to uint32_t by fixing the 32
70 // least significant non-fractional bits in the low 32 bits of the 71 // least significant non-fractional bits in the low 32 bits of the
71 // double, and reading them from there. 72 // double, and reading them from there.
72 const double k2Pow52 = 4503599627370496.0; 73 const double k2Pow52 = 4503599627370496.0;
73 bool negative = x < 0; 74 bool negative = x < 0;
74 if (negative) { 75 if (negative) {
75 x = -x; 76 x = -x;
76 } 77 }
77 if (x < k2Pow52) { 78 if (x < k2Pow52) {
78 x += k2Pow52; 79 x += k2Pow52;
79 uint32_t result; 80 uint32_t result;
80 memcpy(&result, &x, sizeof(result)); // Copy low 32 bits. 81 Address mantissa_ptr;
82 #ifdef BIG_ENDIAN_FLOATING_POINT
83 mantissa_ptr = reinterpret_cast<Address>(&x) + kIntSize;
84 #else
85 mantissa_ptr = reinterpret_cast<Address>(&x);
86 #endif
87 memcpy(&result, mantissa_ptr, sizeof(result)); // Copy low 32 bits.
Erik Corry 2010/03/16 12:12:15 Comment is out of date!
81 return negative ? ~result + 1 : result; 88 return negative ? ~result + 1 : result;
82 } 89 }
83 // Large number (outside uint32 range), Infinity or NaN. 90 // Large number (outside uint32 range), Infinity or NaN.
84 return 0x80000000u; // Return integer indefinite. 91 return 0x80000000u; // Return integer indefinite.
85 } 92 }
86 93
87 94
88 static inline double DoubleToInteger(double x) { 95 static inline double DoubleToInteger(double x) {
89 if (isnan(x)) return 0; 96 if (isnan(x)) return 0;
90 if (!isfinite(x) || x == 0) return x; 97 if (!isfinite(x) || x == 0) return x;
(...skipping 21 matching lines...) Expand all
112 if (!isfinite(x) || x == 0) return 0; 119 if (!isfinite(x) || x == 0) return 0;
113 if (x < 0 || x >= two32) x = modulo(x, two32); 120 if (x < 0 || x >= two32) x = modulo(x, two32);
114 x = (x >= 0) ? floor(x) : ceil(x) + two32; 121 x = (x >= 0) ? floor(x) : ceil(x) + two32;
115 return (int32_t) ((x >= two31) ? x - two32 : x); 122 return (int32_t) ((x >= two31) ? x - two32 : x);
116 } 123 }
117 124
118 125
119 } } // namespace v8::internal 126 } } // namespace v8::internal
120 127
121 #endif // V8_CONVERSIONS_INL_H_ 128 #endif // V8_CONVERSIONS_INL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698