Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 9958147: Fix some uses of global variables in transient pages. (Closed)

Created:
8 years, 8 months ago by Matt Perry
Modified:
8 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix some uses of global variables in transient pages. - contextMenus.create now fetches a unique ID from the browser process instead of a process-wide counter. - tts and socket both keep the transient page alive until their event handlers signal completion, so their process-wide counter remains valid. BUG=119614 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130753

Patch Set 1 #

Total comments: 7

Patch Set 2 : sync #

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -31 lines) Patch
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 4 chunks +40 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 2 3 chunks +42 lines, -26 lines 0 comments Download
M chrome/renderer/extensions/context_menus_custom_bindings.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 2 4 chunks +52 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/tts_custom_bindings.js View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Matt Perry
http://codereview.chromium.org/9958147/diff/1/chrome/common/extensions/extension_messages.h File chrome/common/extensions/extension_messages.h (left): http://codereview.chromium.org/9958147/diff/1/chrome/common/extensions/extension_messages.h#oldcode359 chrome/common/extensions/extension_messages.h:359: IPC_MESSAGE_ROUTED3(ExtensionMsg_InlineWebstoreInstallResponse, I moved the ExtensionMsg's up to their section.
8 years, 8 months ago (2012-04-04 00:32:42 UTC) #1
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/browser/renderer_host/chrome_render_message_filter.cc File chrome/browser/renderer_host/chrome_render_message_filter.cc (right): https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/browser/renderer_host/chrome_render_message_filter.cc#newcode431 chrome/browser/renderer_host/chrome_render_message_filter.cc:431: if (profile_->GetExtensionProcessManager() && service) { Use this instead: ...
8 years, 8 months ago (2012-04-04 18:52:24 UTC) #2
Matt Perry
8 years, 8 months ago (2012-04-04 19:21:44 UTC) #3
https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/browser/renderer...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/browser/renderer...
chrome/browser/renderer_host/chrome_render_message_filter.cc:431: if
(profile_->GetExtensionProcessManager() && service) {
On 2012/04/04 18:52:24, Yoyo Zhou wrote:
> Use this instead: ExtensionProcessManager* process_manager =
> ExtensionSystemFactory::GetForProfile(profile_)->process_manager();

Done.

https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/common/extension...
File chrome/common/extensions/extension_messages.h (right):

https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/common/extension...
chrome/common/extensions/extension_messages.h:266: // Response to the renderer
for the above message.
On 2012/04/04 18:52:24, Yoyo Zhou wrote:
> "the above message" was already wrong, but change it to GetAppNotifyChannel.

Done.

https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/renderer/extensi...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/9958147/diff/1/chrome/renderer/extensi...
chrome/renderer/extensions/extension_dispatcher.cc:160: bool
IsLazyBackgroundPage(const std::string& extension_id) {
On 2012/04/04 18:52:24, Yoyo Zhou wrote:
> This name seems to be... off.

Changed to IsCurrentContextLazyBackgroundPage

Powered by Google App Engine
This is Rietveld 408576698