Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 9958111: Adding a BrowsingDataHelper class to hold some useful methods. (Closed)

Created:
8 years, 8 months ago by Mike West
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding a BrowsingDataHelper class to hold some useful methods. There's simply no good reason to hardcode checks against chrome::kExtensionScheme in various bits of BrowsingData*. BrowsingDataHelper provides a static method that we can start using whenever we need to know about browsing-data-relevant schemes. BUG=121636 TEST=unit_tests:BrowsingDataRemover* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130574

Patch Set 1 : GURL. #

Total comments: 1

Patch Set 2 : Whitespace. #

Patch Set 3 : Rebase onto trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -11 lines) Patch
A chrome/browser/browsing_data_helper.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/browsing_data_helper.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/browsing_data_helper_unittest.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data_remover.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data_remover_unittest.cc View 6 chunks +50 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
Is this more or less what you were suggesting, Jochen? -Mike
8 years, 8 months ago (2012-04-03 14:04:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm http://codereview.chromium.org/9958111/diff/7/chrome/browser/browsing_data_helper.h File chrome/browser/browsing_data_helper.h (right): http://codereview.chromium.org/9958111/diff/7/chrome/browser/browsing_data_helper.h#newcode16 chrome/browser/browsing_data_helper.h:16: class WebString; no indent in namespaces
8 years, 8 months ago (2012-04-03 14:08:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/9958111/2015
8 years, 8 months ago (2012-04-03 14:52:59 UTC) #3
commit-bot: I haz the power
Try job failure for 9958111-2015 (retry) on win_rel for steps "browser_tests, unit_tests". It's a second ...
8 years, 8 months ago (2012-04-03 18:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/9958111/2015
8 years, 8 months ago (2012-04-03 19:01:47 UTC) #5
commit-bot: I haz the power
Try job failure for 9958111-2015 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-03 23:28:52 UTC) #6
Mike West
8 years, 8 months ago (2012-04-04 08:48:51 UTC) #7
I tried to be a good boy. Ended up landing it manually. :)

Powered by Google App Engine
This is Rietveld 408576698