Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/browsing_data_helper_unittest.cc

Issue 9958111: Adding a BrowsingDataHelper class to hold some useful methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase onto trunk. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data_helper.cc ('k') | chrome/browser/browsing_data_remover.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data_helper_unittest.cc
diff --git a/chrome/browser/browsing_data_helper_unittest.cc b/chrome/browser/browsing_data_helper_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a074d2b21fc36cc3d86298f6f4ff7e4d412ac664
--- /dev/null
+++ b/chrome/browser/browsing_data_helper_unittest.cc
@@ -0,0 +1,58 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/browsing_data_helper.h"
+
+#include "base/stringprintf.h"
+#include "chrome/common/url_constants.h"
+#include "content/public/common/url_constants.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "googleurl/src/gurl.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
+
+namespace {
+
+class BrowsingDataHelperTest : public testing::Test {
+ public:
+ BrowsingDataHelperTest() {}
+ virtual ~BrowsingDataHelperTest() {}
+
+ bool IsValidScheme(const std::string& scheme) {
+ GURL test(scheme + "://example.com");
+ return (BrowsingDataHelper::HasValidScheme(test) &&
+ BrowsingDataHelper::IsValidScheme(scheme) &&
+ BrowsingDataHelper::IsValidScheme(
+ WebKit::WebString::fromUTF8(scheme)));
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(BrowsingDataHelperTest);
+};
+
+TEST_F(BrowsingDataHelperTest, WebSafeSchemesAreValid) {
+ EXPECT_TRUE(IsValidScheme(chrome::kHttpScheme));
+ EXPECT_TRUE(IsValidScheme(chrome::kHttpsScheme));
+ EXPECT_TRUE(IsValidScheme(chrome::kFtpScheme));
+ EXPECT_TRUE(IsValidScheme(chrome::kDataScheme));
+ EXPECT_TRUE(IsValidScheme("feed"));
+ EXPECT_TRUE(IsValidScheme(chrome::kBlobScheme));
+ EXPECT_TRUE(IsValidScheme(chrome::kFileSystemScheme));
+
+ EXPECT_FALSE(IsValidScheme("invalid-scheme-i-just-made-up"));
+}
+
+TEST_F(BrowsingDataHelperTest, ChromeSchemesAreInvalid) {
+ EXPECT_FALSE(IsValidScheme(chrome::kExtensionScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kAboutScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kChromeDevToolsScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kChromeInternalScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kChromeUIScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kJavaScriptScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kMailToScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kMetadataScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kSwappedOutScheme));
+ EXPECT_FALSE(IsValidScheme(chrome::kViewSourceScheme));
+}
+
+} // namespace
« no previous file with comments | « chrome/browser/browsing_data_helper.cc ('k') | chrome/browser/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698