Add a library name to the isolate_runtime.dart file.

Add a library name to the isolate_runtime.dart file.

[devoncarew, 2012-04-04 17:24:33]

We're adding the ability to edit system libraries in the editor, but in order to
override a system library we need to identify them. This particular version of
the isolate library was missing a library name.

I made the name match the other isolate libraries (dart:isolate). As an fyi,
most of the other libraries name themselves w/o the dart: prefix. So
#library("foo") instead of #library("dart:foo").

[Siggi Cherem (dart-lang), 2012-04-04 17:43:22]

http://codereview.chromium.org/9950143/diff/1/lib/isolate/isolate_runtime.dart
File lib/isolate/isolate_runtime.dart (right):

http://codereview.chromium.org/9950143/diff/1/lib/isolate/isolate_runtime.dar...
lib/isolate/isolate_runtime.dart:8: #source("runtime/isolate.dart");
-- this line made me realize that this file is actually obsolete. So I'm not
sure if it will serve your purposes.

I initially moved part of the implementation of isolates from the VM here (under
lib/runtime), but that got pushed back.

Currently the VM assembles the isolate library using:
dart/runtime/lib/isolate_sources.gypi

One possibility would be to update this file to say:
#source("../runtime/lib/isolate.dart");

[devoncarew, 2012-04-04 17:50:46]

> lib/isolate/isolate_runtime.dart:8: #source("runtime/isolate.dart");
> -- this line made me realize that this file is actually obsolete. So I'm not
> sure if it will serve your purposes.
> 
> I initially moved part of the implementation of isolates from the VM here
(under
> lib/runtime), but that got pushed back.

We're only using this file for static analysis; we can use a different one if
that would be better. The lib/config directory contains a mapping form the
library name to the file to analyze against. Would it be better to use
lib/isolate/isolate_compiler.dart instead of the runtime one?

[Siggi Cherem (dart-lang), 2012-04-04 18:05:24]

On 2012/04/04 17:50:46, devoncarew wrote:
> > lib/isolate/isolate_runtime.dart:8: #source("runtime/isolate.dart");
> > -- this line made me realize that this file is actually obsolete. So I'm not
> > sure if it will serve your purposes.
> > 
> > I initially moved part of the implementation of isolates from the VM here
> (under
> > lib/runtime), but that got pushed back.
> 
> We're only using this file for static analysis; we can use a different one if
> that would be better. The lib/config directory contains a mapping form the
> library name to the file to analyze against. Would it be better to use
> lib/isolate/isolate_compiler.dart instead of the runtime one?

I see - yes. Either that or isolate_frog.dart would do. isolate_frog.dart has a
bit more documentation on it. isolate_compiler.dart mainly has the API and no
implementation code, so it might be best for your purpose..