Prevent the PasswordManager from provisionally saving data from username-less forms.

Prevent the PasswordManager from provisionally saving data from username-less forms.

Also remove an obsolete comment.

BUG=121612
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132323

[Ilya Sherman, 2012-04-04 04:02:47]

I'm not really following why this code path is reachable, and I'm not able to
reproduce per the bug's repro steps; but it's easy enough to handle this case
without the NOTREACHED(), so let's do it.

[Ilya Sherman, 2012-04-05 22:24:35]

Now with an actual fix.

[Wez, 2012-04-13 16:54:46]

Ping.  Please review & land this ASAP.  Thanks. :)

[Mike Mammarella, 2012-04-13 20:44:05]

On 2012/04/13 16:54:46, Wez wrote:
> Ping.  Please review & land this ASAP.  Thanks. :)

Huh, not sure how I missed this. Tim, thoughts? This isn't really the part of
the password manager that I'm familiar with, but I can rubber stamp if we want
since it's pretty simple.

[Ilya Sherman, 2012-04-13 21:28:57]

On 2012/04/13 20:44:05, Mike Mammarella wrote:
> On 2012/04/13 16:54:46, Wez wrote:
> > Ping.  Please review & land this ASAP.  Thanks. :)
> 
> Huh, not sure how I missed this. Tim, thoughts? This isn't really the part of
> the password manager that I'm familiar with, but I can rubber stamp if we want
> since it's pretty simple.

I think Tim is going to be out for most of next week, so if you're comfortable
reviewing based on the simplicity, please do :)

[Mike Mammarella, 2012-04-13 21:38:29]

OK, LGTM then.

[commit-bot: I haz the power, 2012-04-13 21:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/9950139/3001

[commit-bot: I haz the power, 2012-04-13 23:48:18]

Try job failure for 9950139-3001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-14 00:46:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/9950139/3001

[commit-bot: I haz the power, 2012-04-14 02:27:43]

Try job failure for 9950139-3001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-14 02:30:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/9950139/3001

[commit-bot: I haz the power, 2012-04-14 03:46:32]

Change committed as 132323