Prevent the PasswordManager from provisionally saving data from username-less forms.

chrome/browser/password_manager/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager.h"
 
 #include "base/threading/platform_thread.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_form_manager.h"
 #include "chrome/browser/password_manager/password_manager_delegate.h"
@@ skipping 94 matching lines @@
   // results for the given form and autofill. If this is the case, we just
   // give up.
   if (!manager->HasCompletedMatching())
     return;
 
   // Also get out of here if the user told us to 'never remember' passwords for
   // this form.
   if (manager->IsBlacklisted())
     return;
 
+  // Bail if we're missing any of the necessary form components.
+  if (!manager->HasValidPasswordForm())
+    return;
+
   PasswordForm provisionally_saved_form(form);
   provisionally_saved_form.ssl_valid = form.origin.SchemeIsSecure() &&
       !delegate_->DidLastPageLoadEncounterSSLErrors();
   provisionally_saved_form.preferred = true;
   manager->ProvisionallySave(provisionally_saved_form);
   provisional_save_manager_.swap(manager);
 }
 
 void PasswordManager::SetObserver(LoginModelObserver* observer) {
   observer_ = observer;
@@ skipping 52 matching lines @@
     return;
 
   DCHECK(IsEnabled());
 
   // First, check for a failed login attempt.
   for (std::vector<PasswordForm>::const_iterator iter = visible_forms.begin();
        iter != visible_forms.end(); ++iter) {
     if (provisional_save_manager_->DoesManage(*iter)) {
       // The form trying to be saved has immediately re-appeared. Assume login
       // failure and abort this save, by clearing provisional_save_manager_.
-      // Don't delete the login managers since the user may try again
-      // and we want to be able to save in that case.
       provisional_save_manager_->SubmitFailed();
       provisional_save_manager_.reset();
       return;
     }
   }
 
   if (!provisional_save_manager_->HasValidPasswordForm()) {
     // Form is not completely valid - we do not support it.
     NOTREACHED();
     provisional_save_manager_.reset();
@@ skipping 37 matching lines @@
         observer_->OnAutofillDataAvailable(preferred_match.username_value,
                                            preferred_match.password_value);
       }
   }
 }
 
 bool PasswordManager::IsEnabled() const {
   const Profile* profile = delegate_->GetProfileForPasswordManager();
   return profile && !profile->IsOffTheRecord() && *password_manager_enabled_;
 }