Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 9950098: Fixed bug where the ExecuteJavascript() family of PyAuto hooks ignored the automation id of message… (Closed)

Created:
8 years, 8 months ago by craigdh
Modified:
8 years, 8 months ago
CC:
chromium-reviews, robertshield, kkania, frankf
Visibility:
Public.

Description

Fixed bug where the ExecuteJavascript() family of PyAuto hooks ignored the automation id of messages from DomAutomationController. This had the effect of hooks returning on the next message from DomAutomationController regardless of whether that message actually indicated completion of the injected javascript. BUG=120769 TEST=functional/execute_javascript.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132503

Patch Set 1 #

Patch Set 2 : Found a use where this change broke ExecuteJavascript, this should fix it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
craigdh
8 years, 8 months ago (2012-04-03 17:05:25 UTC) #1
Nirnimesh
LGTM
8 years, 8 months ago (2012-04-03 18:12:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/9950098/1
8 years, 8 months ago (2012-04-04 17:11:55 UTC) #3
commit-bot: I haz the power
Try job failure for 9950098-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-04 18:12:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/9950098/1
8 years, 8 months ago (2012-04-06 20:55:01 UTC) #5
commit-bot: I haz the power
Try job failure for 9950098-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
8 years, 8 months ago (2012-04-06 21:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/9950098/1
8 years, 8 months ago (2012-04-06 22:45:35 UTC) #7
commit-bot: I haz the power
Try job failure for 9950098-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
8 years, 8 months ago (2012-04-06 23:55:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/9950098/25001
8 years, 8 months ago (2012-04-16 23:35:16 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 01:22:51 UTC) #10
Change committed as 132503

Powered by Google App Engine
This is Rietveld 408576698