Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 9950098: Fixed bug where the ExecuteJavascript() family of PyAuto hooks ignored the automation id of message… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Found a use where this change broke ExecuteJavascript, this should fix it. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/automation_provider_observers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 57548ad6771c085306d822e30f749196e91ccd49..da88114e72fc07f1e0a1cead62c281d797a5a067 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -1322,13 +1322,9 @@ void ExecuteJavascriptInRenderViewFrame(
// This routing id needs to be remembered for the reverse
// communication while sending back the response of
// this javascript execution.
- std::string set_automation_id;
- base::SStringPrintf(&set_automation_id,
- "window.domAutomationController.setAutomationId(%d);",
- reply_message->routing_id());
-
render_view_host->ExecuteJavascriptInWebFrame(
- frame_xpath, UTF8ToUTF16(set_automation_id));
+ frame_xpath,
+ UTF8ToUTF16("window.domAutomationController.setAutomationId(0);"));
render_view_host->ExecuteJavascriptInWebFrame(
frame_xpath, script);
}
« no previous file with comments | « chrome/browser/automation/automation_provider_observers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698