Properly parse IPv6 subjectAltNames when USE_OPENSSL is set

Properly parse IPv6 subjectAltNames when USE_OPENSSL is set

BUG=121153
TEST=X509CertificateTest.ParseSubjectAltName
R=agl@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130663

[Ryan Sleevi, 2012-04-03 01:21:52]

agl: This seems right up your alley.

wtc: FYI in case you had any nits. Otherwise, feel free to ignore :)

[agl, 2012-04-03 10:41:22]

LGTM

http://codereview.chromium.org/9950065/diff/3/net/base/x509_certificate_unitt...
File net/base/x509_certificate_unittest.cc (right):

http://codereview.chromium.org/9950065/diff/3/net/base/x509_certificate_unitt...
net/base/x509_certificate_unittest.cc:459: static const unsigned char
kIPv4Address[] = {
s/unsigned char/uint8 ?

http://codereview.chromium.org/9950065/diff/3/net/base/x509_certificate_unitt...
net/base/x509_certificate_unittest.cc:466: static const unsigned char
kIPv6Address[] = {
ditto

[Ryan Sleevi, 2012-04-03 17:17:18]

http://codereview.chromium.org/9950065/diff/3/net/base/x509_certificate_unitt...
File net/base/x509_certificate_unittest.cc (right):

http://codereview.chromium.org/9950065/diff/3/net/base/x509_certificate_unitt...
net/base/x509_certificate_unittest.cc:459: static const unsigned char
kIPv4Address[] = {
On 2012/04/03 10:41:22, agl wrote:
> s/unsigned char/uint8 ?

Done. Since this file was a mixed of unsigned char and uint8, harmonized on
uint8 in this file for style purposes.

[commit-bot: I haz the power, 2012-04-03 17:17:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/9950065/10

[commit-bot: I haz the power, 2012-04-03 18:06:03]

Try job failure for 9950065-10 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[wtc, 2012-04-03 23:11:42]

Patch set 4 LGTM.

http://codereview.chromium.org/9950065/diff/10/net/base/x509_certificate_unit...
File net/base/x509_certificate_unittest.cc (right):

http://codereview.chromium.org/9950065/diff/10/net/base/x509_certificate_unit...
net/base/x509_certificate_unittest.cc:44: uint8 google_fingerprint[] = {

We sometimes use 'unsigned char' to mean a byte, because
uint8 could mean an 8-bit unsigned integer (a number).