Explicitly declare temporary cooked frames state

Explicitly declare temporary cooked frames state

Committed: http://code.google.com/p/v8/source/detail?r=4199

[Peter Rybin, 2010-03-17 22:19:55]

Hi Soren

I noticed that my procedure of frames cooking/uncooking does not always work
(probably only in tests).
In other situations an ASSERT goes off.
So I need a decent way of muting this ASSERT.
What do you think about my approach?

Peter

[Søren Thygesen Gjesse, 2010-03-18 07:46:43]

I will suggest that you just remove the two asserts.

  ASSERT(MarkCompactCollector::IsCompacting()
  ASSERT(MarkCompactCollector::HasCompacted()

I also think you should add some new functions instead of using 

  ThreadManager::MarkCompactPrologue
  ThreadManager::MarkCompactEpilogue

when you visit the heap, as you are not realy doing a mark compact, but
preparing the stack to code object replacement.

[Peter Rybin, 2010-03-18 23:30:01]

I redid so.

Added generic iteration over all inactive threads.

[Søren Thygesen Gjesse, 2010-03-19 07:44:01]

LGTM

http://codereview.chromium.org/995006/diff/9001/10006
File src/v8threads.h (right):

http://codereview.chromium.org/995006/diff/9001/10006#newcode106
src/v8threads.h:106: // Iterate over all inactive threads.
Remove "inactive" from comment.

http://codereview.chromium.org/995006/diff/9001/10006#newcode108
src/v8threads.h:108: // Iterate over all inactive threads.
Ditto.

[Peter Rybin, 2010-03-20 22:33:07]

http://codereview.chromium.org/995006/diff/9001/10006
File src/v8threads.h (right):

http://codereview.chromium.org/995006/diff/9001/10006#newcode106
src/v8threads.h:106: // Iterate over all inactive threads.
On 2010/03/19 07:44:01, Søren Gjesse wrote:
> Remove "inactive" from comment.

I think I should remove the comment altogether better.
I can't think how "all threads" might mean "all threads except the active one".
I think this would be misleading.

http://codereview.chromium.org/995006/diff/9001/10006#newcode108
src/v8threads.h:108: // Iterate over all inactive threads.
On 2010/03/19 07:44:01, Søren Gjesse wrote:
> Ditto.

Same here.