Removed access to prefs that does not work on Android

Removed access to prefs that does not work on Android

This work is useful to make sure at build time that we are not accessing prefs that are not registered.

This CL addresses the prefs registered by:
  BrowserInit::RegisterUserPrefs
  PinnedTabCodec::RegisterUserPrefs
  PluginsUI::RegisterUserPrefs
  PromoResourceService::RegisterUserPrefs

Later CL:
  Browser::RegisterUserPrefs
  SyncPromoUI::RegisterUserPrefs
  *::RegisterPrefs

BUG=120802
TEST=Compiled and made diff-ed the link error to make sure they are the same.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131994

[Yaron, 2012-04-09 17:12:55]

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
File chrome/browser/web_resource/notification_promo.cc (right):

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
chrome/browser/web_resource/notification_promo.cc:356: bool
NotificationPromo::IsBuildAllowed(int builds_allowed) const {
Seems like we might want to remove the PromoResourceService entirely via gyp and
a new build flag like "enable_promo_resource_service" that's off for Android.
With that change, I think you wouldn't even need to touch these files as they'd
be gyp'd out.

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
File chrome/browser/web_resource/notification_promo.h (right):

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
chrome/browser/web_resource/notification_promo.h:71: #if !defined(OS_ANDROID)
Is this necessary given the test change (i.e. removal via gyp)?

http://codereview.chromium.org/9949033/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9949033/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:4545: ['exclude',
'^browser/web_resource/promo_resource_service'],
Perhaps all of browser/web_resource could be excluded or at lesat
notification_promo which is used by promo_resource_service

[Dan Beam, 2012-04-09 17:20:16]

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
File chrome/browser/web_resource/notification_promo.cc (right):

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
chrome/browser/web_resource/notification_promo.cc:356: bool
NotificationPromo::IsBuildAllowed(int builds_allowed) const {
On 2012/04/09 17:12:55, Yaron wrote:
> Seems like we might want to remove the PromoResourceService entirely via gyp
and
> a new build flag like "enable_promo_resource_service" that's off for Android.
> With that change, I think you wouldn't even need to touch these files as
they'd
> be gyp'd out.

+1

[Jerome, 2012-04-09 18:24:05]

adding enable_promo_resource_service and removing the ifdefs there just worked.
Thanks!

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
File chrome/browser/web_resource/notification_promo.cc (right):

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
chrome/browser/web_resource/notification_promo.cc:356: bool
NotificationPromo::IsBuildAllowed(int builds_allowed) const {
On 2012/04/09 17:20:16, Dan Beam wrote:
> On 2012/04/09 17:12:55, Yaron wrote:
> > Seems like we might want to remove the PromoResourceService entirely via gyp
> and
> > a new build flag like "enable_promo_resource_service" that's off for
Android.
> > With that change, I think you wouldn't even need to touch these files as
> they'd
> > be gyp'd out.
> 
> +1

Done.

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
File chrome/browser/web_resource/notification_promo.h (right):

http://codereview.chromium.org/9949033/diff/1/chrome/browser/web_resource/not...
chrome/browser/web_resource/notification_promo.h:71: #if !defined(OS_ANDROID)
On 2012/04/09 17:12:55, Yaron wrote:
> Is this necessary given the test change (i.e. removal via gyp)?

Done.

http://codereview.chromium.org/9949033/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9949033/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:4545: ['exclude',
'^browser/web_resource/promo_resource_service'],
On 2012/04/09 17:12:55, Yaron wrote:
> Perhaps all of browser/web_resource could be excluded or at lesat
> notification_promo which is used by promo_resource_service

Done.

[Yaron, 2012-04-09 18:31:54]

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_impl.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_impl.cc:432: #if !defined(OS_ANDROID)
Change if-def to ENABLE_*.

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_impl.h (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_impl.h:31: #if !defined(OS_ANDROID)
Change these to ENABLE_PROMO_RESOURCE_SERVICE

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:245: return
&NewWebUI<PluginsUI>;
Any reason not to add an exclusion for chrome/browser/ui/webui/plugins_ui to
chrome_browser.gypi?

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:412: #if !defined(OS_ANDROID)
ENABLE_*

http://codereview.chromium.org/9949033/diff/8001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4035: ['exclude',
'^browser/web_resource/promo_resource_service'],
What happened to notification_promo? I guess the linker optimized it out?

http://codereview.chromium.org/9949033/diff/8001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/common/pref_names.cc#...
chrome/common/pref_names.cc:1336: #if !defined(OS_ANDROID)
This one is promo_resource_service, right?

[Jerome, 2012-04-09 20:10:52]

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_impl.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_impl.cc:432: #if !defined(OS_ANDROID)
On 2012/04/09 18:31:54, Yaron wrote:
> Change if-def to ENABLE_*. 

Done.

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_impl.h (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_impl.h:31: #if !defined(OS_ANDROID)
On 2012/04/09 18:31:54, Yaron wrote:
> Change these to ENABLE_PROMO_RESOURCE_SERVICE

Done.

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:245: return
&NewWebUI<PluginsUI>;
On 2012/04/09 18:31:54, Yaron wrote:
> Any reason not to add an exclusion for chrome/browser/ui/webui/plugins_ui to
> chrome_browser.gypi?

Good point.

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:412: #if !defined(OS_ANDROID)
On 2012/04/09 18:31:54, Yaron wrote:
> ENABLE_*

Done.

http://codereview.chromium.org/9949033/diff/8001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4035: ['exclude',
'^browser/web_resource/promo_resource_service'],
On 2012/04/09 18:31:54, Yaron wrote:
> What happened to notification_promo? I guess the linker optimized it out?

Yep it was not needed anymore.

http://codereview.chromium.org/9949033/diff/8001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/9949033/diff/8001/chrome/common/pref_names.cc#...
chrome/common/pref_names.cc:1336: #if !defined(OS_ANDROID)
On 2012/04/09 18:31:54, Yaron wrote:
> This one is promo_resource_service, right?

yes. Done.

[Yaron, 2012-04-09 20:38:55]

lgtm

Please find appropriate OWNERS for the relevant sub-dirs

http://codereview.chromium.org/9949033/diff/9012/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/9949033/diff/9012/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:413: // If the user has
preferences for a start and end time for a promo from
Nit: Move this into the above if-clause.

[Jerome, 2012-04-09 22:17:30]

http://codereview.chromium.org/9949033/diff/9012/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/9949033/diff/9012/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:413: // If the user has
preferences for a start and end time for a promo from
On 2012/04/09 20:38:55, Yaron wrote:
> Nit: Move this into the above if-clause. 

Done.

[Jerome, 2012-04-09 22:33:16]

Dave, please review changes in:
chrome/browser/profiles/

James, please review changes in:
chrome/browser/ui/webui/
chrome/
chrome/common/

Thanks!

[Jerome, 2012-04-11 03:51:19]

Ping :)

[James Hawkins, 2012-04-11 18:24:36]

LGTM

[DaveMoore, 2012-04-12 14:43:53]

lgtm

[commit-bot: I haz the power, 2012-04-12 14:47:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jscholler@chromium.org/9949033/15002

[commit-bot: I haz the power, 2012-04-12 16:14:33]

Change committed as 131994