Removed access to prefs that does not work on Android

chrome/browser/web_resource/notification_promo.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/notification_promo.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/rand_util.h"
@@ skipping 335 matching lines @@
   if (prefs_->HasPrefPath(prefs::kNtpPromoViewsMax))
     max_views_ = prefs_->GetInteger(prefs::kNtpPromoViewsMax);
 
   if (prefs_->HasPrefPath(prefs::kNtpPromoViews))
     views_ = prefs_->GetInteger(prefs::kNtpPromoViews);
 
   prefs_->SetInteger(prefs::kNtpPromoViews, ++views_);
   return views_ >= max_views_;
 }
 
 bool NotificationPromo::IsBuildAllowed(int builds_allowed) const {

[Yaron, 2012/04/09 17:12:55]

Seems like we might want to remove the PromoResourceService entirely via gyp and
a new build flag like "enable_promo_resource_service" that's off for Android.
With that change, I think you wouldn't even need to touch these files as they'd
be gyp'd out.

[Dan Beam, 2012/04/09 17:20:16]

+1

[Jerome, 2012/04/09 18:24:06]

Done.

+#if !defined(OS_ANDROID)
   if (delegate_)  // For testing.
     return delegate_->IsBuildAllowed(builds_allowed);
   else
     return PromoResourceService::IsBuildTargeted(
         PromoResourceService::GetChannel(), builds_allowed);
+#else
+  return false;
+#endif
 }
 
 bool NotificationPromo::IsPlatformAllowed(int target_platform) const {
   const int current_platform = delegate_? delegate_->CurrentPlatform()
                                         : CurrentPlatform();
   return (target_platform & current_platform) != 0;
 }
 
 // static
 int NotificationPromo::CurrentPlatform() {
@@ skipping 45 matching lines @@
          max_group_ == other.max_group_ &&
          max_views_ == other.max_views_ &&
          platform_ == other.platform_ &&
          group_ == other.group_ &&
          views_ == other.views_ &&
          text_ == other.text_ &&
          closed_ == other.closed_ &&
          gplus_ == other.gplus_ &&
          feature_mask_ == other.feature_mask_;
 }