Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 99343: Cleanup include guards: (Closed)

Created:
11 years, 7 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Cleanup include guards: - Fix some typos / guards that didn't match the filename. - Fix some style inconsistencies. - Add guards to files that were missing them. - Add the directory name to the guard.

Patch Set 1 #

Patch Set 2 : Fix for include/v8-debug.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -76 lines) Patch
M include/v8-debug.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/assembler-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/codegen-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/constants-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/frames-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/simulator-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/dateparser-inl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/debug.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/debug-agent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/frames-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/simulator-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/regexp-macro-assembler-irregexp-inl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/regexp-macro-assembler-tracer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/regexp-stack.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/shell.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/unicode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/unicode-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/usage-analyzer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/v8-counters.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
11 years, 7 months ago (2009-05-04 13:23:53 UTC) #1
Erik Corry
11 years, 7 months ago (2009-05-04 13:29:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698