Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 99266: Deprecate wstring version of PathService::Get() in webkit. (Closed)

Created:
11 years, 7 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Deprecate wstring version of PathService::Get() in webkit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15032

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -42 lines) Patch
M base/event_recorder.h View 3 chunks +4 lines, -2 lines 0 comments Download
M base/event_recorder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/event_recorder_stubs.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_init.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/node_leak_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 7 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
11 years, 7 months ago (2009-05-01 01:04:21 UTC) #1
tony
LGTM! http://codereview.chromium.org/99266/diff/1/8 File webkit/tools/test_shell/test_shell.cc (right): http://codereview.chromium.org/99266/diff/1/8#newcode600 Line 600: bool GetExeDirectory(std::wstring *path) { It would be ...
11 years, 7 months ago (2009-05-01 01:12:12 UTC) #2
Lei Zhang
11 years, 7 months ago (2009-05-01 01:18:47 UTC) #3
On 2009/05/01 01:12:12, tony wrote:
> LGTM!
> 
> http://codereview.chromium.org/99266/diff/1/8
> File webkit/tools/test_shell/test_shell.cc (right):
> 
> http://codereview.chromium.org/99266/diff/1/8#newcode600
> Line 600: bool GetExeDirectory(std::wstring *path) {
> It would be good to some day find out why we have 2 identical functions, but
> that would be for a different change.

For GetApplicationDirectory(), webkit_glue.h says:

Gets the directory where the application data and libraries exist.  This may be
a versioned subdirectory, or it may be the same directory as the
GetExeDirectory(), depending on the embedder's implementation.

I guess it's the same on our implementation.

Powered by Google App Engine
This is Rietveld 408576698