Issue 99248: Don't show popups before tabs have been added. Instead, prevent the BrowserVi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99248: Don't show popups before tabs have been added. Instead, prevent the BrowserVi... (Closed)

Created:
11 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Don't show popups before tabs have been added. Instead, prevent the BrowserView from restoring focus to the tab if the window that contains it isn't visible. This prevents blur events from being fired incorrectly. http://crbug.com/7991 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14985

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+1 line, -8 lines	0 comments	Download
	M	chrome/browser/views/frame/browser_view.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

OK