Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: chrome/browser/browser.cc

Issue 99248: Don't show popups before tabs have been added. Instead, prevent the BrowserVi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 14954)
+++ chrome/browser/browser.cc (working copy)
@@ -2601,15 +2601,8 @@
browser->set_maximized_state(MAXIMIZED_STATE_UNMAXIMIZED);
browser->CreateBrowserWindow();
- // We need to Show before AddNewContents, otherwise AddNewContents will focus
- // it (via BrowserView::TabSelectedAt calling RestoreFocus), triggering any
- // onblur="" handlers.
+ browser->tabstrip_model()->AppendTabContents(new_contents, true);
browser->window()->Show();
-
- // TODO(beng): See if this can be made to use
- // TabStripModel::AppendTabContents.
- browser->AddNewContents(source, new_contents, NEW_FOREGROUND_TAB,
- gfx::Rect(), true);
}
GURL Browser::GetHomePage() const {
« no previous file with comments | « no previous file | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698