Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 99247: Stop the location bar from flashing white when navigating from one HTTPS site... (Closed)

Created:
11 years, 7 months ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Stop the location bar from flashing white when navigating from one HTTPS site to another. To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen. BUG=11157 TEST=Navigate from one HTTPS site to another and watch the location bar carefully. It shouln't flash anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15020

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M chrome/browser/ssl/ssl_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 1 chunk +10 lines, -2 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
11 years, 7 months ago (2009-04-30 20:45:55 UTC) #1
Peter Kasting
11 years, 7 months ago (2009-04-30 22:07:54 UTC) #2
LGTM

http://codereview.chromium.org/99247/diff/1/4
File chrome/browser/tab_contents/navigation_controller.cc (right):

http://codereview.chromium.org/99247/diff/1/4#newcode869
Line 869: NotificationDetails out_details =
Details<LoadCommittedDetails>(details);
Nit: Perhaps |notification_details| instead of |out_details|?

http://codereview.chromium.org/99247/diff/1/4#newcode873
Line 873: // This is to work around the fact that parts of the location bar draw
I would just eliminate these last two lines and append "when it wants to draw"
to the end of the previous sentence.

Powered by Google App Engine
This is Rietveld 408576698