Stop the location bar from flashing white when navigating from one HTTPS site...

chrome/browser/tab_contents/navigation_controller.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/navigation_controller.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/time.h"
@@ skipping 847 matching lines @@
     DCHECK(pending_entry_index_ != -1);
     pending_entry_ = entries_[pending_entry_index_].get();
   }
 
   if (!tab_contents_->NavigateToPendingEntry(reload))
     DiscardNonCommittedEntries();
 }
 
 void NavigationController::NotifyNavigationEntryCommitted(
     LoadCommittedDetails* details) {
+  details->entry = GetActiveEntry();
+  NotificationDetails out_details = Details<LoadCommittedDetails>(details);

[Peter Kasting, 2009/04/30 22:07:54]

Nit: Perhaps |notification_details| instead of |out_details|?

+
+  // We need to notify the ssl_manager_ before the tab_contents_ so the
+  // location bar will have up-to-date information about the security style.
+  // This is to work around the fact that parts of the location bar draw

[Peter Kasting, 2009/04/30 22:07:54]

I would just eliminate these last two lines and append "when it wants to draw"
to the end of the previous sentence.

+  // synchronously.  See http://crbug.com/11157
+  ssl_manager_.DidCommitProvisionalLoad(out_details);
+
   // TODO(pkasting): http://b/1113079 Probably these explicit notification paths
   // should be removed, and interested parties should just listen for the
   // notification below instead.
   tab_contents_->NotifyNavigationStateChanged(
       TabContents::INVALIDATE_EVERYTHING);
 
-  details->entry = GetActiveEntry();
   NotificationService::current()->Notify(
       NotificationType::NAV_ENTRY_COMMITTED,
       Source<NavigationController>(this),
-      Details<LoadCommittedDetails>(details));
+      out_details);
 }
 
 // static
 void NavigationController::DisablePromptOnRepost() {
   check_for_repost_ = false;
 }
 
 void NavigationController::SetActive(bool is_active) {
   if (is_active) {
     if (needs_reload_) {
@@ skipping 60 matching lines @@
       return i;
   }
   return -1;
 }
 
 NavigationEntry* NavigationController::GetTransientEntry() const {
   if (transient_entry_index_ == -1)
     return NULL;
   return entries_[transient_entry_index_].get();
 }