Issue 99238: Add notification (and unit test) for closing prefs window so it can be cleane...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99238: Add notification (and unit test) for closing prefs window so it can be cleane... (Closed)

Created:
11 years, 7 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add notification (and unit test) for closing prefs window so it can be cleaned up properly in the app controller. Make the prefs window controller the window's delegate so it gets close notifications. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14967

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -6 lines)			Patch
M	chrome/app/nibs/en.lproj/Preferences.xib	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller_unittest.mm	View		2 chunks	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages