chrome/browser/cocoa/preferences_window_controller.mm - Issue 99238: Add notification (and unit test) for closing prefs window so it can be cleane...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/preferences_window_controller.mm

Issue 99238: Add notification (and unit test) for closing prefs window so it can be cleane... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/preferences_window_controller.h ('k') | chrome/browser/cocoa/preferences_window_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/preferences_window_controller.mm

===================================================================

--- chrome/browser/cocoa/preferences_window_controller.mm (revision 14958)

+++ chrome/browser/cocoa/preferences_window_controller.mm (working copy)

@@ -7,7 +7,8 @@

#include "base/mac_util.h"

#include "chrome/common/pref_service.h"

-PreferencesWindowController* gPrefWindowSingleton = nil;

+NSString* const kUserDoneEditingPrefsNotification =

+ @"kUserDoneEditingPrefsNotification";

@implementation PreferencesWindowController

@@ -42,8 +43,9 @@

// Called when the window is being closed. Send out a notification that the

// user is done editing preferences.

- (void)windowWillClose:(NSNotification *)notification {

- // TODO(pinkerton): send notification. Write unit test that makes sure

- // we receive it.

+ [[NSNotificationCenter defaultCenter]

+ postNotificationName:kUserDoneEditingPrefsNotification

+ object:self];

}

@end