Issue 99235: Silence off the DeprecationWarning in upload.py when running python >=2.5. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(202)

My Issues | Starred Open | Closed | All

Issue 99235: Silence off the DeprecationWarning in upload.py when running python >=2.5. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
berendjanwever, jam

CC:
chromium-reviews_googlegroups.com, SkyLined

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Load hashlib when available and md5 otherwise. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15043

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	upload.py	View	1 2 3 4	4 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

BJ had a change that works around this: http://codereview.chromium.org/92159 BJ: can you check your version ...

11 years, 7 months ago (2009-04-30 19:53:11 UTC) #2

M-A Ruel

I changed the way I made it and I prefer my way. What do you ...

11 years, 7 months ago (2009-04-30 20:07:04 UTC) #3

LGTM

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698