Issue 92159: Work around for md5 module deprecation warning in python 2.5+

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92159: Work around for md5 module deprecation warning in python 2.5+ (Closed)

Created:
11 years, 8 months ago by SkyLined

Modified:
9 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Description

If you have python 2.5+ installed, a deprecation warning for the md5 module is displayed whenever upload.py is used. This change forces the code to use hashlib when it is available (python 2.5+) and prevents the warning. This has been replaced by http://codereview.chromium.org/99235

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	static/upload.py	View	1	3 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

SkyLined

If you have python 2.5+ installed, a deprecation warning for the md5 module is displayed ...

11 years, 8 months ago (2009-04-24 21:24:09 UTC) #1

lgtm

Expand Messages | Collapse Messages