- Use a local flag to tell if the project already has an 'All' target, and do...

- Use a local flag to tell if the project already has an 'All' target, and don't generate one (assume they are controlling it for a reason)
- When generating an 'All' target, only do it if there are tests that are allowed to be included (avoid case of the targets being marked to not include in a wildcard match)
- Add a xcode specific flag to generates a "test runner" for all tests dependent on a given target, this removes the special case code for all.gyp from Chromium.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=456

[Mark Mentovai, 2009-04-30 17:56:37]

lg

http://codereview.chromium.org/99223/diff/1001/1002
File pylib/gyp/generator/xcode.py (right):

http://codereview.chromium.org/99223/diff/1001/1002#newcode154
Line 154: if target_name == 'All':
Maybe check target_name.lower() == 'all'?  This has always bugged me a little.

http://codereview.chromium.org/99223/diff/1001/1002#newcode197
Line 197: # "All" target it first so that people opening up the project for the
first
Get rid of "it"

http://codereview.chromium.org/99223/diff/1001/1002#newcode262
Line 262: # To support making a "test runner" target that will run all the test
that
all the tests (s)

http://codereview.chromium.org/99223/diff/1001/1002#newcode263
Line 263: # are dependencies of any given target, we look for
Say "direct dependents".  Dependencies go the other way.

http://codereview.chromium.org/99223/diff/1001/1002#newcode310
Line 310: # Insert after the target this was generated from.
Awkward.  "Insert the test runner after the related target" or something?