Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: pylib/gyp/input.py

Issue 99223: - Use a local flag to tell if the project already has an 'All' target, and do... (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/generator/xcode.py ('K') | « pylib/gyp/generator/xcode.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/input.py
===================================================================
--- pylib/gyp/input.py (revision 452)
+++ pylib/gyp/input.py (working copy)
@@ -1198,6 +1198,8 @@
def SetUpConfigurations(target, target_dict):
# non_configuraiton_keys is a list of key names that belong in the target
# itself and should not be propagated into its configurations.
+ # TODO(mark/tvl): we need a way for this list to be extended by the
+ # generators.
non_configuration_keys = [
# Sections that must exist inside targets and not configurations.
'actions',
@@ -1219,6 +1221,7 @@
'test',
'type',
'variants',
+ 'xcode_create_dependents_test_runner',
# Sections that can be found inside targets or configurations, but that
# should not be propagated from targets into their configurations.
« pylib/gyp/generator/xcode.py ('K') | « pylib/gyp/generator/xcode.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698