Second attempt at cleaning up handling of --disable-popup-blocking. I didn't...

Second attempt at cleaning up handling of --disable-popup-blocking.  I didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab.  This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab.

I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14886

[Elliot Glaysher, 2009-04-29 21:01:04]

I was curious because of all the talk about cleaning this up. I found an email
from Patrick about why he implemented this feature this way:

"This is needed for Selenium support.  A common use case is to run Selenium
tests in two windows - one main window and another for the application under
test.  Selenium opens the new window for the AUT by calling window.open from its
onLoad handler.  Chrome treats this as an unsolicited pop-up and
minimizes/blocks it (rightfully so).  But of course in this case that's not the
desired effect (it's nice to see the tests running).  The common technique
Selenium uses with other browsers is to disable the pop-up blocker, so it makes
sense for Chrome to support that option too."

The actual code changes LGTM, but you may be breaking things downstream that use
Selenium. I'm not entirely sure.