Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Side by Side Diff: chrome/renderer/render_view.h

Issue 99203: Second attempt at cleaning up handling of --disable-popup-blocking. I didn't... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/unload_uitest.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_ 5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_
6 #define CHROME_RENDERER_RENDER_VIEW_H_ 6 #define CHROME_RENDERER_RENDER_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <queue> 9 #include <queue>
10 #include <vector> 10 #include <vector>
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 WebFrame* GetChildFrame(const std::wstring& frame_xpath) const; 612 WebFrame* GetChildFrame(const std::wstring& frame_xpath) const;
613 613
614 std::string GetAltHTMLForTemplate(const DictionaryValue& error_strings, 614 std::string GetAltHTMLForTemplate(const DictionaryValue& error_strings,
615 int template_resource_id) const; 615 int template_resource_id) const;
616 616
617 virtual void DidAddHistoryItem(); 617 virtual void DidAddHistoryItem();
618 618
619 // Decodes a data: URL image or returns an empty image in case of failure. 619 // Decodes a data: URL image or returns an empty image in case of failure.
620 SkBitmap ImageFromDataUrl(const GURL&) const; 620 SkBitmap ImageFromDataUrl(const GURL&) const;
621 621
622 // A helper method used by WasOpenedByUserGesture.
623 bool WasOpenedByUserGestureHelper() const;
624
625 void DumpLoadHistograms() const; 622 void DumpLoadHistograms() const;
626 623
627 // Bitwise-ORed set of extra bindings that have been enabled. See 624 // Bitwise-ORed set of extra bindings that have been enabled. See
628 // BindingsPolicy for details. 625 // BindingsPolicy for details.
629 int enabled_bindings_; 626 int enabled_bindings_;
630 627
631 // DOM Automation Controller CppBoundClass. 628 // DOM Automation Controller CppBoundClass.
632 DomAutomationController dom_automation_controller_; 629 DomAutomationController dom_automation_controller_;
633 630
634 // Chrome page<->browser messaging CppBoundClass. 631 // Chrome page<->browser messaging CppBoundClass.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 731
735 // DevToolsClient for renderer hosting developer tools UI. It's NULL for other 732 // DevToolsClient for renderer hosting developer tools UI. It's NULL for other
736 // render views. 733 // render views.
737 scoped_ptr<DevToolsClient> devtools_client_; 734 scoped_ptr<DevToolsClient> devtools_client_;
738 735
739 scoped_ptr<WebFileChooserCallback> file_chooser_; 736 scoped_ptr<WebFileChooserCallback> file_chooser_;
740 737
741 int history_back_list_count_; 738 int history_back_list_count_;
742 int history_forward_list_count_; 739 int history_forward_list_count_;
743 740
744 // True if pop-up blocking is disabled. False by default.
745 bool disable_popup_blocking_;
746
747 // True if the page has any frame-level unload or beforeunload listeners. 741 // True if the page has any frame-level unload or beforeunload listeners.
748 bool has_unload_listener_; 742 bool has_unload_listener_;
749 743
750 // The total number of unrequested popups that exist and can be followed back 744 // The total number of unrequested popups that exist and can be followed back
751 // to a common opener. This count is shared among all RenderViews created 745 // to a common opener. This count is shared among all RenderViews created
752 // with CreateWebView(). All popups are treated as unrequested until 746 // with CreateWebView(). All popups are treated as unrequested until
753 // specifically instructed otherwise by the Browser process. 747 // specifically instructed otherwise by the Browser process.
754 scoped_refptr<SharedRenderViewCounter> shared_popup_counter_; 748 scoped_refptr<SharedRenderViewCounter> shared_popup_counter_;
755 749
756 // Whether this is a top level window (instead of a popup). Top level windows 750 // Whether this is a top level window (instead of a popup). Top level windows
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
798 scoped_refptr<AudioMessageFilter> audio_message_filter_; 792 scoped_refptr<AudioMessageFilter> audio_message_filter_;
799 793
800 // The currently selected text. This is currently only updated on Linux, where 794 // The currently selected text. This is currently only updated on Linux, where
801 // it's for the selection clipboard. 795 // it's for the selection clipboard.
802 std::string selection_text_; 796 std::string selection_text_;
803 797
804 DISALLOW_COPY_AND_ASSIGN(RenderView); 798 DISALLOW_COPY_AND_ASSIGN(RenderView);
805 }; 799 };
806 800
807 #endif // CHROME_RENDERER_RENDER_VIEW_H_ 801 #endif // CHROME_RENDERER_RENDER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/unload_uitest.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698