Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 99186: Create build structure for X64. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Create build structure for X64. Possible to attempt to build for X64. Build will be unsuccessful, since all x64 source files are missing and pointers are reinterpreted as integers everywhere.

Patch Set 1 #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -36 lines) Patch
M SConstruct View 8 chunks +40 lines, -11 lines 3 comments Download
M src/SConscript View 1 chunk +12 lines, -2 lines 2 comments Download
M src/codegen.h View 1 chunk +8 lines, -2 lines 2 comments Download
M src/execution.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/frames-inl.h View 1 chunk +8 lines, -2 lines 2 comments Download
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/jsregexp.cc View 3 chunks +21 lines, -6 lines 0 comments Download
M src/macro-assembler.h View 1 chunk +10 lines, -4 lines 0 comments Download
M src/platform-freebsd.cc View 2 chunks +2 lines, -1 line 2 comments Download
M src/platform-linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/virtual-frame.h View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Compiler switches for compiling X64 code. Only allowed if both wordsize=32 and arch=x64 are supplied, ...
11 years, 7 months ago (2009-04-29 11:57:16 UTC) #1
Mads Ager (chromium)
LGTM Could you please add the new files as well? You can just add empty ...
11 years, 7 months ago (2009-04-29 12:27:24 UTC) #2
Lasse Reichstein
11 years, 7 months ago (2009-04-29 13:05:41 UTC) #3
Addressed comments.

http://codereview.chromium.org/99186/diff/1/2
File SConstruct (right):

http://codereview.chromium.org/99186/diff/1/2#newcode155
Line 155: },
Not needed. I would prefer to have it everywhere (makes reordering much easier),
but since it's not the style, I should go for consistency instead.

http://codereview.chromium.org/99186/diff/1/3
File src/SConscript (right):

http://codereview.chromium.org/99186/diff/1/3#newcode78
Line 78: # 'x64/regexp-macro-assembler-x64.cc',
Because we can actually do without it. The test for whether to use native or
interpreted regexp is set to use the interpreter (like on ARM).

http://codereview.chromium.org/99186/diff/1/4
File src/codegen.h (right):

http://codereview.chromium.org/99186/diff/1/4#newcode79
Line 79: #ifdef V8_ARCH_ARM
Attempted done. No guarantees on the XCode project file. It's not made for hand
editing.

http://codereview.chromium.org/99186/diff/1/6
File src/frames-inl.h (right):

http://codereview.chromium.org/99186/diff/1/6#newcode37
Line 37: #include "ia64/frames-ia64.h"
Yes, my bad.

http://codereview.chromium.org/99186/diff/1/11
File src/platform-freebsd.cc (right):

http://codereview.chromium.org/99186/diff/1/11#newcode174
Line 174: #ifdef (defined(__arm__) || defined(__thumb__))
Fixed.

Powered by Google App Engine
This is Rietveld 408576698