Issue 99161: Handle all accelerators in focus manager when focused view doesn't want to ta...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99161: Handle all accelerators in focus manager when focused view doesn't want to ta... (Closed)

Created:
11 years, 8 months ago by hamaji

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Handle all accelerators in focus manager when focused view doesn't want to take a crack. - Removed prioritary_accelerators_only from FocusManager::ProcessAccelerator(). - Fixed a TODO in task manager so that now it uses accelerator for button. - Eliminated unnecessary code in FocusManager. - Made LocationBarView skip accelerators when the key event is needed by omnibox. BUG=11073

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -57 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_manager.cc	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	2	1 chunk	+35 lines, -5 lines	0 comments	Download
M	chrome/views/controls/tree/tree_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/views/focus/focus_manager.h	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/views/focus/focus_manager.cc	View	1	2 chunks	+19 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hamaji

Thanks for the advices on the issue tracker! I'll updated this change. Now, could you ...

11 years, 7 months ago (2009-04-29 20:29:34 UTC) #1

hamaji

11 years, 7 months ago (2009-04-30 16:55:15 UTC) #3

Thanks you for the review! Could you check this in and close the bug?

Thanks,

On 2009/04/30 16:48:06, jcampan wrote:
> LGTM
> 
> Thanks for fixing this!
> 
> Jay

Expand Messages | Collapse Messages